Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query should be on the list of extra args #365

Merged
merged 3 commits into from
May 23, 2024

Conversation

alvarowolfx
Copy link
Contributor

The fix on #361 actually missed passing the query within the list of extra args, as on methods returning more than two arguments, the query is suppose to be on the list.

Example with BigQuery:

const [rows, q, response] = await bigqueryClient.query(sqlQuery, options)
// rows is the list of items accumulated with rows from all paginated calls
// q is initial Query
// response is the last call Response

@alvarowolfx alvarowolfx requested a review from a team as a code owner May 22, 2024 20:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 22, 2024
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: xs Pull request size is extra small. labels May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 22, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 22, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@alvarowolfx alvarowolfx merged commit 50e40d0 into googleapis:main May 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants