fix!: users can log httprequest logs without providing a log message

src/log.ts

@@ -425,10 +425,16 @@ class Log implements LogSeverityFunctions {
    */
   entry(metadataOrData?: LogEntry | string | {}, data?: string | {}) {
     let metadata: LogEntry;
-    if (!data) {
+    if (!data && metadataOrData?.hasOwnProperty('httpRequest')) {
+      // If user logs entry(httpRequest)
+      metadata = metadataOrData as LogEntry;
+      data = {};
+    } else if (!data) {
+      // If user logs entry(message)
       data = metadataOrData as string | {};
       metadata = {};
     } else {
+      // If user logs entry(metadata, message)
       metadata = metadataOrData as LogEntry;
     }
     return this.logging.entry(metadata, data);

system-test/logging.ts

@@ -539,6 +539,30 @@ describe('Logging', () => {
       });
     });
 
+    it('should write a httpRequest log with no message', done => {
+      const {log} = getTestLog();
+      const metadata = {
+        httpRequest: {status: 200},
+      };
+      const logEntry = log.entry(metadata);
+
+      log.write(logEntry, err => {
+        assert.ifError(err);
+
+        getEntriesFromLog(log, {numExpectedMessages: 1}, (err, entries) => {
+          assert.ifError(err);
+          const entry = entries![0];
+
+          assert.strictEqual(
+            entry.metadata.httpRequest?.status,
+            metadata.httpRequest.status
+          );
+          assert.deepStrictEqual(entry.data, {});
+          done();
+        });
+      });
+    });
+
     it('should set the default resource', done => {
       const {log} = getTestLog();
 

test/log.ts

@@ -243,11 +243,19 @@ describe('Log', () => {
       assert(log.logging.entry.calledWithExactly(metadata, data));
     });
 
-    it('should assume one argument means data', () => {
+    it('should assume one regular argument means data', () => {
       const data = {};
       log.entry(data);
       assert(log.logging.entry.calledWith(sinon.match.any, data));
     });
+
+    it('should assume one httpRequest argument means metadata', () => {
+      const metadata = {
+        httpRequest: {},
+      };
+      log.entry(metadata);
+      assert(log.logging.entry.calledWith(metadata, {}));
+    });
   });
 
   describe('getEntries', () => {