Release @google-cloud/logging v4.5.2

[ofrobots]

This pull request was generated using releasetool.

[ofrobots]

What I am not clear on is why #439 is marked as a fix. Isn't it a feature?

[codecov]

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          14       14           
  Lines         681      681           
  Branches       34       34           
=======================================
  Hits          622      622           
  Misses         41       41           
  Partials       18       18

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a003cd8...9753151. Read the comment docs.

[JustinBeckwith]

Not sure how to look at that one. @alexander-fenster any thoughts?

[alexander-fenster]

@JustinBeckwith @alexander-fenster re: #439, these added headers are required by the spec for all calls which have variable assignment in google.api.http annotation (e.g. post: "v1/{parent=projects/*}/foo") but in most cases, it actually works without those headers. In this sense, we are fixing a bug by making the implementation follow the spec it did not follow before, and it does not change any behavior, so for me callling it a fix: (and not a feat:) is fine.

[ofrobots]

Thanks @alexander-fenster . That context was not apparent from the PR itself. For future PRs, can we get a better description so that it is easier to determine semverity?

[JustinBeckwith]

That one is on me. Right now our tools in this space aren't very great. There's no way to preserve context from a change in the generator to the changes in the underlying library. As a result, we often have to guess based on the changed output what happened. We are trying to find ways to make this better, but it's unlikely to happen until we transition to the micro-generator.

[yoshi-automation]

Release is at https://github.com/googleapis/nodejs-logging/releases/tag/v4.5.2

[yoshi-automation]

The release build has started, the log can be viewed here. 🌻

[yoshi-automation]

🥚 You hatched a release! The release build finished successfully! 💜