fix(ts): do not require storage/pubsub types, add install test

package.json

@@ -83,6 +83,8 @@
     "@types/extend": "^3.0.0",
     "@types/is": "0.0.21",
     "@types/mocha": "^5.2.5",
+    "@types/mv": "^2.1.0",
+    "@types/ncp": "^2.0.1",
     "@types/nock": "^9.3.0",
     "@types/on-finished": "^2.3.1",
     "@types/pify": "^3.0.2",
@@ -105,6 +107,8 @@
     "jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
     "linkinator": "^1.1.2",
     "mocha": "^6.0.0",
+    "mv": "^2.1.1",
+    "ncp": "^2.0.0",
     "nock": "^10.0.1",
     "nyc": "^13.0.1",
     "power-assert": "^1.6.0",

src/index.ts

@@ -66,7 +66,9 @@ export type DeleteResponse = google.protobuf.Empty;
 export type LogSink = google_config.logging.v2.ILogSink;
 
 export interface CreateSinkRequest {
-  destination: Bucket|Dataset|Topic|string;
+  // destination: Bucket|Dataset|Topic|string;
+  // tslint:disable-next-line no-any
+  destination: any;
   filter?: string;
   includeChildren?: boolean;
   name?: string;

system-test/fixtures/sample/package.json

@@ -0,0 +1,23 @@
+{
+  "name": "logging-sample-fixture",
+  "description": "An app we're using to test the library.",
+  "scripts": {
+    "check": "gts check",
+    "clean": "gts clean",
+    "compile": "tsc -p .",
+    "fix": "gts fix",
+    "prepare": "npm run compile",
+    "pretest": "npm run compile",
+    "posttest": "npm run check",
+    "start": "node build/src/index.js"
+  },
+  "license": "Apache-2.0",
+  "dependencies": {
+    "@google-cloud/logging": "file:./logging.tgz"
+  },
+  "devDependencies": {
+    "@types/node": "^10.3.0",
+    "typescript": "^3.0.0",
+    "gts": "^0.9.0"
+  }
+}

system-test/fixtures/sample/src/index.ts

@@ -0,0 +1,6 @@
+import {Logging} from '@google-cloud/logging';
+async function main() {
+  const logging = new Logging();
+  console.log(logging);
+}
+main();

system-test/fixtures/sample/tsconfig.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./node_modules/gts/tsconfig-google.json",
+  "compilerOptions": {
+    "rootDir": ".",
+    "outDir": "build"
+  },
+  "include": [
+    "src/*.ts"
+  ]
+}

system-test/install.ts

@@ -0,0 +1,56 @@
+/**
+ * Copyright 2019 Google LLC. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as execa from 'execa';
+import * as mv from 'mv';
+import {ncp} from 'ncp';
+import * as tmp from 'tmp';
+import {promisify} from 'util';
+
+const keep = false;
+const mvp = promisify(mv) as {} as (...args: string[]) => Promise<void>;
+const ncpp = promisify(ncp);
+const stagingDir = tmp.dirSync({keep, unsafeCleanup: true});
+const stagingPath = stagingDir.name;
+const pkg = require('../../package.json');
+
+describe('📦 pack and install', () => {
+  /**
+   * Create a staging directory with temp fixtures used to test on a fresh
+   * application.
+   */
+  it('should be able to use the d.ts', async () => {
+    await execa('npm', ['pack', '--unsafe-perm']);
+    const tarball = `google-cloud-logging-${pkg.version}.tgz`;
+    await mvp(tarball, `${stagingPath}/logging.tgz`);
+    await ncpp('system-test/fixtures/sample', `${stagingPath}/`);
+    await execa(
+        'npm', ['install', '--unsafe-perm'],
+        {cwd: `${stagingPath}/`, stdio: 'inherit'});
+    await execa(
+        'node', ['--throw-deprecation', 'build/src/index.js'],
+        {cwd: `${stagingPath}/`, stdio: 'inherit'});
+  });
+
+  /**
+   * CLEAN UP - remove the staging directory when done.
+   */
+  after('cleanup staging', () => {
+    if (!keep) {
+      stagingDir.removeCallback();
+    }
+  });
+});