Skip to content

chore: release 1.0.0#326

Merged
DominicKramer merged 4 commits into
masterfrom
release-v1.0.0
Jun 11, 2019
Merged

chore: release 1.0.0#326
DominicKramer merged 4 commits into
masterfrom
release-v1.0.0

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented May 20, 2019

🤖 I have created a release *beep* *boop*

1.0.0 (2019-06-11)

⚠ BREAKING CHANGES

Bug Fixes

  • expose express middleware, add system-test (#278) (dc17ad7)
  • use immutable winston level (#319) (450295f)
  • deps: bump minimum required dependencies (#336) (fc87d65)
  • deps: update dependency @google-cloud/logging to v5 (#324) (059c2a1)
  • deps: update dependency google-auth-library to v4 (#317) (6182968)

Build System

Code Refactoring

Miscellaneous Chores


This PR was generated with Release Please.

@yoshi-automation yoshi-automation added autorelease: pending type: process A process-related concern. May include testing, release, or the like. labels May 20, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2019

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files           4        4           
  Lines         101      101           
  Branches       23       23           
=======================================
  Hits           96       96           
  Misses          2        2           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d666e...cb1563f. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2019

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files           4        4           
  Lines         101      101           
  Branches       23       23           
=======================================
  Hits           96       96           
  Misses          2        2           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46f385...e693f09. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 5, 2019
@DominicKramer DominicKramer added status: blocked Resolving the issue is dependent on other work. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed 🚨 This issue needs some love. labels Jun 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@DominicKramer
Copy link
Copy Markdown
Contributor

This is blocked by the samples and lint tests not passing. This looks like it could be a configuration problem because I opened PR #334 that uses the exact same code as this PR, and all the tests pass fine. @googleapis/yoshi-nodejs does anyone have a suggestion on how I can proceed here (or know how to fix the errors shown in the tests) to get the release out. Thanks.

@bcoe
Copy link
Copy Markdown

bcoe commented Jun 7, 2019

@DominicKramer is there a chance something was fixed in a patch release since this was opened? I'd try pushing an empty commit at this branch.

@DominicKramer
Copy link
Copy Markdown
Contributor

DominicKramer commented Jun 10, 2019

@bcoe pushing an empty commit didn't help, but I was able to reproduce the error locally. When running the samples test, the following is done:

npm install

# Install and link samples
cd samples/
npm link ../
npm install
cd ..

npm run samples-test

The first three commands work fine, but when running npm install after npm link ../, npm reports an error saying that @google-cloud/logging-winston@^1.0.0 can't be found.

I've double checked the package.json files in the repo root and samples directory and compared the configuration to the @google-cloud/logging-bunyan repo (where the sample tests are working fine), and I don't see anything that would cause the failures seen.

I can fix the problem by removing @google-cloud/logging-winston@^1.0.0 as a dependency in samples/package.json since the npm link ../ command already makes a link to @google-cloud/logging-winston@^1.0.0 in samples/node_modules, but this seems like the wrong thing to do.

Do you have any suggestions on how to proceed or have you seen this error before? Thanks for the help.

@bcoe
Copy link
Copy Markdown

bcoe commented Jun 10, 2019

@DominicKramer I believe the culprit might be the old version referenced in package-lock.json.

@yoshi-automation
Copy link
Copy Markdown
Contributor Author

@yoshi-automation
Copy link
Copy Markdown
Contributor Author

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Copy Markdown
Contributor Author

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorelease: published cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants