chore: release 1.0.0#326
Conversation
c307ed6 to
b3d666e
Compare
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 4 4
Lines 101 101
Branches 23 23
=======================================
Hits 96 96
Misses 2 2
Partials 3 3Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 4 4
Lines 101 101
Branches 23 23
=======================================
Hits 96 96
Misses 2 2
Partials 3 3Continue to review full report at Codecov.
|
cb1563f to
b3d666e
Compare
bfac2da to
059c2a1
Compare
b2febf5 to
059c2a1
Compare
d4c9b7e to
c83050b
Compare
0163a24 to
c83050b
Compare
1cff487 to
c83050b
Compare
ec25fe7 to
c83050b
Compare
5019b07 to
2d72bc1
Compare
421ee36 to
2d72bc1
Compare
|
This is blocked by the samples and lint tests not passing. This looks like it could be a configuration problem because I opened PR #334 that uses the exact same code as this PR, and all the tests pass fine. @googleapis/yoshi-nodejs does anyone have a suggestion on how I can proceed here (or know how to fix the errors shown in the tests) to get the release out. Thanks. |
|
@DominicKramer is there a chance something was fixed in a patch release since this was opened? I'd try pushing an empty commit at this branch. |
bc059da to
2d72bc1
Compare
|
@bcoe pushing an empty commit didn't help, but I was able to reproduce the error locally. When running the samples test, the following is done: The first three commands work fine, but when running I've double checked the I can fix the problem by removing Do you have any suggestions on how to proceed or have you seen this error before? Thanks for the help. |
|
@DominicKramer I believe the culprit might be the old version referenced in |
|
The release build has started, the log can be viewed here. 🌻 |
|
🥚 You hatched a release! The release build finished successfully! 💜 |
🤖 I have created a release *beep* *boop*
1.0.0 (2019-06-11)
⚠ BREAKING CHANGES
Bug Fixes
Build System
Code Refactoring
Miscellaneous Chores
This PR was generated with Release Please.