fix: de-flake system tests #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The test timeout was not effectively applied. 2. All of the tests needed a longer timeout rather than just the error reporting ones. 3. The error-reporting tests would race with a concurrent execution of the tests in the CI because they were logging and polling against the same service. Uniquify the service name.
googlebot
added
the
cla: yes
ofrobots
added a commit
to googleapis/nodejs-logging-bunyan
that referenced
this pull request
Feb 13, 2019
Ref: googleapis/nodejs-logging-winston#265 1. Synchronize the system test with logging-winston. Use the same structure and reliable mechanism for polling. 2. Apply the timeout uniformly across the test. 3. Use unique serviceContext for the error reporting tests to ensure concurrent executions of the tests do no race.
ofrobots
added a commit
to googleapis/nodejs-logging-bunyan
that referenced
this pull request
Feb 13, 2019
Ref: googleapis/nodejs-logging-winston#265 1. Synchronize the system test with logging-winston. Use the same structure and reliable mechanism for polling. 2. Apply the timeout uniformly across the test. 3. Use unique serviceContext for the error reporting tests to ensure concurrent executions of the tests do no race.
JustinBeckwith
pushed a commit
to googleapis/nodejs-logging-bunyan
that referenced
this pull request
Feb 13, 2019
* fix: de-flake system tests Ref: googleapis/nodejs-logging-winston#265 1. Synchronize the system test with logging-winston. Use the same structure and reliable mechanism for polling. 2. Apply the timeout uniformly across the test. 3. Use unique serviceContext for the error reporting tests to ensure concurrent executions of the tests do no race. * fix: disabled tests had were not being run These tests were not even running before because of the errant describe.only in logging-bunyan.ts fixed in the previous commit. Fix. Deflake.
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 14, 2026
* fix: de-flake system tests Ref: googleapis/nodejs-logging-winston#265 1. Synchronize the system test with logging-winston. Use the same structure and reliable mechanism for polling. 2. Apply the timeout uniformly across the test. 3. Use unique serviceContext for the error reporting tests to ensure concurrent executions of the tests do no race. * fix: disabled tests had were not being run These tests were not even running before because of the errant describe.only in logging-bunyan.ts fixed in the previous commit. Fix. Deflake.
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 21, 2026
* fix: de-flake system tests Ref: googleapis/nodejs-logging-winston#265 1. Synchronize the system test with logging-winston. Use the same structure and reliable mechanism for polling. 2. Apply the timeout uniformly across the test. 3. Use unique serviceContext for the error reporting tests to ensure concurrent executions of the tests do no race. * fix: disabled tests had were not being run These tests were not even running before because of the errant describe.only in logging-bunyan.ts fixed in the previous commit. Fix. Deflake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reporting ones.
the tests in the CI because they were logging and polling against
the same service. Uniquify the service name.
Evidence of 2:
The default timeout was 10s.