Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support non-ISO-8859-1 Collection Names in Queries #697

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 20, 2019

Updates google-gax to 1.1.2 to pull in googleapis/gax-nodejs#521 and adds tests to verify that we can query non-Ascii collection.

Adds tests to verify that we can query non-Ascii collection
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@schmidt-sebastian schmidt-sebastian changed the title Deps: Update google-gax to 1.1.2 fix: Support non-ISO-8859-1 Collection Names in Queries Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #697 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   96.22%   96.09%   -0.14%     
==========================================
  Files          20       20              
  Lines        2227     2227              
  Branches      470      470              
==========================================
- Hits         2143     2140       -3     
- Misses         20       22       +2     
- Partials       64       65       +1
Impacted Files Coverage Δ
dev/src/watch.ts 96.52% <0%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686a9c1...84aadeb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #697 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   96.22%   96.09%   -0.14%     
==========================================
  Files          20       20              
  Lines        2227     2227              
  Branches      470      470              
==========================================
- Hits         2143     2140       -3     
- Misses         20       22       +2     
- Partials       64       65       +1
Impacted Files Coverage Δ
dev/src/watch.ts 96.52% <0%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686a9c1...84aadeb. Read the comment docs.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but do we know why the collection path is getting sent as "metadata" in the first place and if that's something we should dig into? Seems like a minor waste of bandwidth if nothing else...?

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Jun 20, 2019

go/grpc-request-params should answer all your questions. The metadata translates to HTTP headers, which some system at some point will use for something useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants