test: Add a metric service client test and ensure universe domain gets used when writing the metrics #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
danieljbruce
changed the title
…s used when writing the metrics
…ogleapis/nodejs-bigtable into 359913994-universe-domain-csm
bhshkh
approved these changes
Aug 7, 2025
1 task
danieljbruce
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a test to make sure the universe domain is used when writing metrics.
Impact
Adds a test to ensure metrics are always written to the right place when universe domain is provided.
Testing
Assuming the MetricServiceClient is working properly, this test ensures that universe domain is passed to the metric service client so that metrics will be written to the universe domain endpoint.
An even better test would be to set up a project at a different universe domain and check it for metrics after a write to ensure the metrics are actually getting written there, but that setup is a pretty heavy lift. I think the current test gives us enough confidence that the test is working correctly.