Skip to content

Conversation

@kevkim-codes
Copy link
Contributor

Add conformance known test failure logs and clean up kokoro script

@kevkim-codes kevkim-codes requested review from a team as code owners November 1, 2024 15:31
@generated-files-bot
Copy link

generated-files-bot bot commented Nov 1, 2024

Warning: This pull request is touching the following templated files:

  • .kokoro/coerce_logs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/conformance.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Nov 1, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Nov 1, 2024
@kevkim-codes kevkim-codes changed the title Conformance cleanup: Conformance Nov 1, 2024
@kevkim-codes kevkim-codes changed the title cleanup: Conformance test: log conformance test failures in failure logs Nov 1, 2024
@kevkim-codes kevkim-codes added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 1, 2024
@kevkim-codes kevkim-codes added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 1, 2024
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a value add, but I wonder if there is a way in each PR we could actually automatically log and see which conformance tests are failing so that we can see the progress over time without any more manual changes.

@kevkim-codes kevkim-codes merged commit c4e2356 into googleapis:main Nov 4, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants