-
Notifications
You must be signed in to change notification settings - Fork 62
feat: Add feature for copying backups #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danieljbruce
merged 143 commits into
googleapis:main
from
danieljbruce:copy-backup-2-relevant-changes-only
May 22, 2024
Merged
Changes from all commits
Commits
Show all changes
143 commits
Select commit
Hold shift + click to select a range
46ce5b8
src test and protos copied over
danieljbruce 576550d
lint fix
danieljbruce 31a1d9a
implemented copy backup
danieljbruce 90e290e
part of test done
danieljbruce 7bce08d
workaround
danieljbruce 29a736f
corrections to get code working
danieljbruce edc30d3
Add expire time
danieljbruce c8a16fc
This allows the copy backup endpoint to work
danieljbruce 2d5320c
Working system test
danieljbruce adabd71
delete try block
danieljbruce 89f742e
tests pass with new refactor
danieljbruce d4f5d47
Create backup and copy on another cluster
danieljbruce ea43929
modifications to second test
danieljbruce bb6e708
copy backup unit test
danieljbruce c96442a
Revert "lint fix"
danieljbruce 701badc
Revert "src test and protos copied over"
danieljbruce 448e41d
First correction
danieljbruce 7407fa2
Check the list of backups
danieljbruce 4eba7d3
fetched backup
danieljbruce 9c21e29
get name and id
danieljbruce c87a4d9
Remove only
danieljbruce a5c1ce2
refactor request mock
danieljbruce 3ee1ec3
Add unit test for copying backup to another projec
danieljbruce 1d80cf4
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 081ddac
feat: add experimental reverse scan for public preview
gcf-owl-bot[bot] 2315c78
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0c07e7c
feat: Increase the maximum retention period for a Cloud Bigtable back…
gcf-owl-bot[bot] 2330a56
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] aa5bab3
docs: fix formatting for reversed order field example
gcf-owl-bot[bot] 967bd71
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0075152
feat: add last_scanned_row_key feature
gcf-owl-bot[bot] c97b89f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] fbdf7d4
fix: fix typings for IAM methods
gcf-owl-bot[bot] 8c685fd
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 38d7961
test: disable retry-request for streaming tests
gcf-owl-bot[bot] e4d2229
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 77d105f
Merge branch 'main' into owl-bot-copy
sofisl a69c8c6
feat: publish CopyBackup protos to external customers
gcf-owl-bot[bot] d3387d3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 452eef0
fix: simplify logic for HTTP/1.1 REST fallback option
gcf-owl-bot[bot] d7c4e94
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] c142deb
fix: add feature flag for improved mutate rows throttling
gcf-owl-bot[bot] fbe0b0c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 11148fb
Merge branch 'main' into owl-bot-copy
sofisl e055215
run lint
sofisl 463666a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 3318e84
Merge branch 'main' into copy-backup-2-relevant-changes-only
meredithslota c932b4c
build: update typescript generator version to publish in dual format …
gcf-owl-bot[bot] db741f2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0b91bb6
feat: Add support for Cloud Bigtable Request Priorities in App Profiles
gcf-owl-bot[bot] 307a8cb
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] ee33f43
Merge branch 'main' into owl-bot-copy
danieljbruce a3a4d9c
build: update Node.js generator to compile protos
gcf-owl-bot[bot] e554f92
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 3a1cd27
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 3f594b2
Merge branch 'owl-bot-copy' of https://github.com/googleapis/nodejs-b…
danieljbruce 4ffb7a1
Use the destination backup expiry time
danieljbruce 8073653
Use the config instead for copy backup
danieljbruce e1f2dde
Rename CopyBackupConfig
danieljbruce f66ee04
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 13e128d
Fix signature of copyBackup
danieljbruce b1af9c1
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
danieljbruce 4c0310c
Change the copy signature to require callback
danieljbruce d61e1cc
Some debugging on the system tests
danieljbruce e2a8be5
DestinationBackupConfig
danieljbruce 763115b
lint fix
danieljbruce 1827059
Move the config and create a generic callback
danieljbruce 3259115
Eliminate the generic callback data structure
danieljbruce 4534399
Get the first copy backup test working
danieljbruce 0836841
Fix different cluster, different instance test
danieljbruce 49f693f
Add another test for copy backup
danieljbruce 67d5eb0
Add a test case for copying to another project
danieljbruce 2ef42e6
Restructure tests for multiple expire time inputs
danieljbruce 86a0311
Various changes to test interaction with copy back
danieljbruce f163aba
Finish the restore tests and modify copy backup
danieljbruce a27f29f
Add comment describing second argument
danieljbruce 80f0154
Remove TODO
danieljbruce 3b95726
Modify copy backup unit test
danieljbruce ae0e313
Modify the name of the test
danieljbruce df282b4
Test for gax options in the test
danieljbruce 99e3d8c
TODO is done
danieljbruce 3dddc0b
Change comment slightly
danieljbruce 5a0d07b
Eliminate TODO
danieljbruce e4d38d4
Fix documentation for source function
danieljbruce 6a26bde
Move copy backup code to proper place
danieljbruce e7e1eb3
Use cluster instead of parent
danieljbruce d859a33
Change parent to cluster
danieljbruce b2c728f
A couple cleanup changes
danieljbruce 377d5bc
Use parent instead of cluster
danieljbruce 1520f22
Eliminate unused time references
danieljbruce 74cbffa
This test should not have changed
danieljbruce 26289af
Eliminate unused import
danieljbruce c5ba924
Remove assert statement that is not needed
danieljbruce ffb9588
Move two lines of code to location used
danieljbruce 1fe2ef0
Improve readability
danieljbruce 9c79b43
Inline variables instead of using them explicitly
danieljbruce 7ab1c96
Generate the backup id inline
danieljbruce 842b70b
readability - indent code so it is separate
danieljbruce 3872ff0
Indent block to separate check
danieljbruce 02078e5
indent cluster creation, expiry time check
danieljbruce 5ac03be
Another test cleanup
danieljbruce 4bd4777
Add comment
danieljbruce 7ee2f18
Indent code for table data insertion
danieljbruce 1a0e153
Rename variables to distinguish operations
danieljbruce e3fdbd2
Eliminate unused imports
danieljbruce b232315
should be lower case
danieljbruce 9890fd8
Change comment to respect alignment
danieljbruce 56c7b7f
Inline callback, config and cluster
danieljbruce 83b7e7e
Remove unused operation
danieljbruce af77ce8
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce b6fa45a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] a3c83bd
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
gcf-owl-bot[bot] d63f892
Delete an instance
danieljbruce d2de338
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
danieljbruce 9e8731d
Inline generate id
danieljbruce 2695d96
Add second project to config
danieljbruce cc8ce59
Rename the function to setBackupExpiryTime
danieljbruce 45ef624
Replace the project for backup path
danieljbruce 835c827
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 2518d3d
Run the linter
danieljbruce 40f3cc2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] dc149e6
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 165ce36
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
danieljbruce 0720df1
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
danieljbruce 22e9bec
Update comments for the copy function
danieljbruce dfc03bf
Rename function that sets correct value of expiry
danieljbruce 8cba026
Add an environment variable for second project
danieljbruce d0a0e1f
Add log for second project
danieljbruce 3b16183
Remove the console log
danieljbruce 6a46c8c
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 9253c9c
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 4e49ab7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] ff3e603
Rename bigtable to bigtableSecondaryProject
danieljbruce fcae645
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
danieljbruce 307d110
PR follow-ups - inline code and rename variables
danieljbruce 69318a0
Merge branch 'main' into copy-backup-2-relevant-changes-only
danieljbruce 1b334a1
Remove unused import
danieljbruce 781516f
Add comments for expire time
danieljbruce 9a48759
Add better garbage cleanups of the backups
danieljbruce 71c5bef
These comments are not needed anymore.
danieljbruce 2089c64
Remove only
danieljbruce 4bc7a7d
Update system-test/bigtable.ts
danieljbruce 661c927
Update system-test/bigtable.ts
danieljbruce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.