refactor(internal/librarian/php): add protoc.RunOrSystem helper and use it in generator - #6719
Merged
Merged
Conversation
…se it in generator
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper function RunOrSystem in the protoc package to execute either a configured protoc tool or fall back to the system's protoc. This helper is integrated into both the Java and PHP generation packages, simplifying the code and removing manual fallback logic. The feedback suggests simplifying a redundant nil check in internal/librarian/php/generate.go since protoc.RunOrSystem already handles nil pointers gracefully.
sofisl
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use protoc.Run in php generate.
Followup to #6703.
For #6629