refactor(internal/librarian/php): use helper funcs for generateAPI - #6718
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the PHP API generation logic in internal/librarian/php/generate.go by extracting several helper functions: gatherTargetProtos, buildProtocArgs, and extractOutput. It also removes unnecessary blank lines and adds comprehensive unit tests for these new helper functions in generate_test.go. I have no further feedback to provide as the changes are clean, well-tested, and follow the repository's style guidelines.
sofisl
approved these changes
Jul 9, 2026
zhumin8
enabled auto-merge (squash)
July 9, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor generateAPI for readability.
Followup to #6703.
For #6629