-
Notifications
You must be signed in to change notification settings - Fork 62
feat(internal/librarian/php): add inital PHP client library generator #6703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c1c7e46
feat(internal/librarian/php): add inital PHP client library generator
zhumin8 9ae2f7b
add setup php step to ci
zhumin8 52732dd
ignore yamlfmt for now, use errors.Is
zhumin8 4c8b991
fix yamlfmt ignore
zhumin8 71d039d
update to install step to use composer
zhumin8 77bc231
chore(tool/cmd/coverage): set PHP component coverage target to 70%
zhumin8 e49a9f8
add todo comment
zhumin8 e272d6a
move generator install steps to install subcommand
zhumin8 70d29cf
fix install add wrapper script
zhumin8 76cc97d
adjust coverage target temporarily
zhumin8 f6b4e80
add tests
zhumin8 3482bc7
test changes, feedback
zhumin8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # The PHP generator (gapic-generator-php) has a preprocessor bug (fixYaml) | ||
| # that incorrectly indents top-level keys if they immediately follow indented blocks. | ||
| # The workaround requires keeping blank lines between top-level keys in | ||
| # secretmanager_v1.yaml, which the default yamlfmt settings would otherwise strip. | ||
| # We exclude the file here to prevent yamlfmt from formatting it. | ||
| # TODO(https://github.com/googleapis/gapic-generator-php/issues/837): determine to remove | ||
| # this workaround or adjust testdata to keep blank lines. | ||
| exclude: | ||
| - "internal/testdata/googleapis/google/cloud/secretmanager/v1/secretmanager_v1.yaml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.