feat(internal/librarian/java): add whitespace formatting helpers for README rendering - #6592
Closed
yangyzs wants to merge 3 commits into
Closed
feat(internal/librarian/java): add whitespace formatting helpers for README rendering#6592yangyzs wants to merge 3 commits into
yangyzs wants to merge 3 commits into
Conversation
…README Add minLeadingSpaces and trimLeadingWhitespace helper functions to calculate and normalize code snippet indentation for README block rendering. Add unit tests in readme_test.go. For googleapis#6515
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds two helper functions, minLeadingSpaces and trimLeadingWhitespace, along with their corresponding unit tests, to compute and trim the minimum leading indentation from a slice of lines. The review feedback correctly identifies that the conditional check len(line) >= minSpaces in trimLeadingWhitespace is redundant since non-empty lines are guaranteed to have at least minSpaces characters, and suggests simplifying the code by removing the unreachable else branch.
Signed-off-by: yangyzs <171981480+yangyzs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minLeadingSpaces and trimLeadingWhitespace helper functions to calculate and normalize code snippet indentation for README block rendering. Add unit tests in readme_test.go.
For #6515