-
Notifications
You must be signed in to change notification settings - Fork 60
feat(internal/librarian): populate Java Maven coordinates from defaults #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
24f5683
feat: fill group id from defaults
JoeWang1127 7825029
add unit tests
JoeWang1127 668480f
add comments
JoeWang1127 f41253d
docs
JoeWang1127 896ea81
update unit tests
JoeWang1127 341ba9a
format
JoeWang1127 7e77e71
update unit tests
JoeWang1127 6e2d753
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 6673862
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 3cddc81
do not fill prefix
JoeWang1127 790cfe8
do not override existing id
JoeWang1127 1c26fa2
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 68a35b7
update name
JoeWang1127 175798f
exact match
JoeWang1127 3c8d35c
format
JoeWang1127 2bd892a
docs
JoeWang1127 b9c3a2b
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 b9141cd
add unit tests
JoeWang1127 f8679fa
update unit tests
JoeWang1127 27782bd
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 ca360b7
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 cc42c83
review
JoeWang1127 8b82d17
format
JoeWang1127 93bc421
update unit tests
JoeWang1127 19ae443
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 f6b7948
replace break to return
JoeWang1127 5ea00de
create helper func
JoeWang1127 9ad74d3
comment
JoeWang1127 088e723
refactor
JoeWang1127 02767a2
Merge branch 'main' into feat/group-id-mapping
JoeWang1127 81dbf1d
do not return lib
JoeWang1127 abcb0b9
return
JoeWang1127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.