Skip to content

fix: Validate the embeddings size to catch silent embeddings batch failures #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Validate the embeddings size to catch silent embeddings batch failures #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a465f
Validate the embeddings size to catch silent embeddings batch failures
aperepel Oct 9, 2024
9e224b6
Merge branch 'main' into patch-3
averikitsch Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/langchain_google_spanner/vector_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,13 @@ def add_texts(

embeds = self._embedding_service.embed_documents(texts_list)

if len(embeds) != number_of_records:
raise ValueError(
"Number of embeddings should equal the number of documents."
"Try reducing the batch size when adding the documents."
f" Expected: {number_of_records}, but found {len(embeds)}"
)

if metadatas is None:
metadatas = [{} for _ in texts]

Expand Down
Loading