Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes #1976

Merged
merged 2 commits into from
Apr 11, 2023
Merged

docs: Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f200a9c
docs: Update spec for WriteObjectRequest.object_size to clarify that …
gcf-owl-bot[bot] Apr 11, 2023
811113e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/stub/GrpcStorageStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ public class GrpcStorageStub extends StorageStub {
private static final PathTemplate DELETE_OBJECT_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
private static final PathTemplate CANCEL_RESUMABLE_WRITE_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
private static final PathTemplate GET_OBJECT_0_PATH_TEMPLATE = PathTemplate.create("{bucket=**}");
private static final PathTemplate READ_OBJECT_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
Expand All @@ -487,7 +487,7 @@ public class GrpcStorageStub extends StorageStub {
private static final PathTemplate START_RESUMABLE_WRITE_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=**}");
private static final PathTemplate QUERY_WRITE_STATUS_0_PATH_TEMPLATE =
PathTemplate.create("{bucket=projects/*/buckets/*}/**");
PathTemplate.create("{bucket=projects/*/buckets/*}:**");
private static final PathTemplate GET_SERVICE_ACCOUNT_0_PATH_TEMPLATE =
PathTemplate.create("{project=**}");
private static final PathTemplate CREATE_HMAC_KEY_0_PATH_TEMPLATE =
Expand Down
4 changes: 2 additions & 2 deletions proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "ncelResumableWriteRequest\032/.google.stora"
+ "ge.v2.CancelResumableWriteResponse\"A\212\323\344\223"
+ "\002/\022-\n\tupload_id\022 {bucket=projects/*/buck"
+ "ets/*}/**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
+ "ets/*}:**\332A\tupload_id\022\225\001\n\tGetObject\022#.go"
+ "ogle.storage.v2.GetObjectRequest\032\031.googl"
+ "e.storage.v2.Object\"H\212\323\344\223\002\027\022\025\n\006bucket\022\013{"
+ "bucket=**}\332A\rbucket,object\332A\030bucket,obje"
Expand Down Expand Up @@ -841,7 +841,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "storage.v2.QueryWriteStatusRequest\032+.goo"
+ "gle.storage.v2.QueryWriteStatusResponse\""
+ "A\212\323\344\223\002/\022-\n\tupload_id\022 {bucket=projects/*"
+ "/buckets/*}/**\332A\tupload_id\022\200\001\n\021GetServic"
+ "/buckets/*}:**\332A\tupload_id\022\200\001\n\021GetServic"
+ "eAccount\022+.google.storage.v2.GetServiceA"
+ "ccountRequest\032!.google.storage.v2.Servic"
+ "eAccount\"\033\212\323\344\223\002\013\022\t\n\007project\332A\007project\022\225\001"
Expand Down
6 changes: 0 additions & 6 deletions proto-google-cloud-storage-v2/src/main/java/com/google/storage/v2/WriteObjectSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ public long getIfMetagenerationNotMatch() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -348,7 +347,6 @@ public boolean hasObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down Expand Up @@ -1487,7 +1485,6 @@ public Builder clearIfMetagenerationNotMatch() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1508,7 +1505,6 @@ public boolean hasObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1529,7 +1525,6 @@ public long getObjectSize() {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -1554,7 +1549,6 @@ public Builder setObjectSize(long value) {
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down
2 changes: 0 additions & 2 deletions ...google-cloud-storage-v2/src/main/java/com/google/storage/v2/WriteObjectSpecOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ public interface WriteObjectSpecOrBuilder
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand All @@ -229,7 +228,6 @@ public interface WriteObjectSpecOrBuilder
* This situation is considered a client error, and if such an error occurs
* you must start the upload over from scratch, this time sending the correct
* number of bytes.
* The `object_size` value is ignored for one-shot (non-resumable) writes.
* </pre>
*
* <code>optional int64 object_size = 8;</code>
Expand Down
6 changes: 2 additions & 4 deletions proto-google-cloud-storage-v2/src/main/proto/google/storage/v2/storage.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ service Storage {
option (google.api.routing) = {
routing_parameters {
field: "upload_id"
path_template: "{bucket=projects/*/buckets/*}/**"
path_template: "{bucket=projects/*/buckets/*}:**"
}
};
option (google.api.method_signature) = "upload_id";
Expand Down Expand Up @@ -391,7 +391,7 @@ service Storage {
option (google.api.routing) = {
routing_parameters {
field: "upload_id"
path_template: "{bucket=projects/*/buckets/*}/**"
path_template: "{bucket=projects/*/buckets/*}:**"
}
};
option (google.api.method_signature) = "upload_id";
Expand Down Expand Up @@ -963,8 +963,6 @@ message WriteObjectSpec {
// This situation is considered a client error, and if such an error occurs
// you must start the upload over from scratch, this time sending the correct
// number of bytes.
//
// The `object_size` value is ignored for one-shot (non-resumable) writes.
optional int64 object_size = 8;
}

Expand Down