Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add matchGlob parameter to BlobListOption #1965

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

briantruong777
Copy link
Contributor

This is a new feature (b/236167515) where List Objects allows filtering results based on a provided glob pattern.

Currently only the JSON API supports the matchGlob parameter, so using the option with gRPC will throw an exception. gRPC support is planned for later.

This is a new feature (b/236167515) where List Objects allows filtering
results based on a provided glob pattern.

Currently only the JSON API supports the matchGlob parameter, so using
the option with gRPC will throw an exception. gRPC support is planned
for later.
@briantruong777 briantruong777 requested a review from a team as a code owner April 4, 2023 02:20
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Apr 4, 2023
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 4, 2023
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to the exception construction.

@briantruong777
Copy link
Contributor Author

Updated to use throwHttpJsonOnly(). PTAL.

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@BenWhitehead
Copy link
Collaborator

Change not impacted by owlbot, merging.

@BenWhitehead BenWhitehead merged commit 93be97a into googleapis:main Apr 5, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 12, 2023
🤖 I have created a release *beep* *boop*
---


## [2.22.0](https://github.com/googleapis/java-storage/compare/v2.21.0...v2.22.0) (2023-04-12)


### Features

* Add matchGlob parameter to BlobListOption ([#1965](https://github.com/googleapis/java-storage/issues/1965)) ([93be97a](https://github.com/googleapis/java-storage/commit/93be97a9ae061241f510cbeb566f9f839063faa0))
* Handle generation numbers in BlobId#{to,from}GsUtilUri ([#1929](https://github.com/googleapis/java-storage/issues/1929)) ([0a033b3](https://github.com/googleapis/java-storage/commit/0a033b36a2be7e1d92c8b2f7323f2851005034cf))
* Implement GrpcStorageImpl#{get,list,create,delete}Notification ([#1958](https://github.com/googleapis/java-storage/issues/1958)) ([830052b](https://github.com/googleapis/java-storage/commit/830052b3f26337f50770436784f0ea9f3366dbca))
* Make it possible to disable the buffer of ReadChannels returned from Storage.reader ([#1974](https://github.com/googleapis/java-storage/issues/1974)) ([702ab2b](https://github.com/googleapis/java-storage/commit/702ab2bb1ceb9f428296591adc6e09023b4a8484))


### Bug Fixes

* Update GrpcStorageOptions to set allowNonDefaultServiceAccount = true ([#1977](https://github.com/googleapis/java-storage/issues/1977)) ([f1b9493](https://github.com/googleapis/java-storage/commit/f1b94930509c87ecbdbe6627fec6118305331780))


### Documentation

* Update spec for WriteObjectRequest.object_size to clarify that it applies to both one-shot and resumable writes ([#1976](https://github.com/googleapis/java-storage/issues/1976)) ([7354e19](https://github.com/googleapis/java-storage/commit/7354e198521384cd2b8583f073217a5a6cb74fe0))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.7.0 ([#1978](https://github.com/googleapis/java-storage/issues/1978)) ([1f7e9c9](https://github.com/googleapis/java-storage/commit/1f7e9c9130a9516acfcdfda4b23e642fbe799146))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#1979](https://github.com/googleapis/java-storage/issues/1979)) ([d6accdf](https://github.com/googleapis/java-storage/commit/d6accdf9c81419728c39a61e348a61683dc117ad))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Jun 5, 2024
Source-Link: googleapis/synthtool@bd2bae8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:72f0d373307d128b2cb720c5cb4d90b31f0e86529dd138c632710ae0c69efae3
sydney-munro pushed a commit that referenced this pull request Jun 5, 2024
Source-Link: googleapis/synthtool@bd2bae8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:72f0d373307d128b2cb720c5cb4d90b31f0e86529dd138c632710ae0c69efae3

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants