test: add test to verify lifecycle.rule.condition.age_days = 0
#1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero (0) is a special value for some serialization configurations. Add a test to ensure it is properly passed to the backend, and is effective.
product-auto-label
bot
added
the
api: storage
frankyn
reviewed
Jan 12, 2023
| } | ||
| conditionBuilder.setMatchesPrefix(condition.getMatchesPrefixList()); | ||
| conditionBuilder.setMatchesSuffix(condition.getMatchesSuffixList()); | ||
| if (!condition.getMatchesPrefixList().isEmpty()) { |
Contributor
There was a problem hiding this comment.
this change looks out of context, is it needed as well?
Collaborator
Author
There was a problem hiding this comment.
It's a difference between what is constructed via
LifecycleRule d1 =
new LifecycleRule(
LifecycleAction.newAbortIncompleteMPUploadAction(),
LifecycleCondition.newBuilder().setAge(0).build());
And what is decoded coming back from the service via grpc. By simply setting as we were doing before the value would be empty list rather than null. Apiary on the other hand will be null by default. This change brings these both in line with the apiary behavior.
frankyn
approved these changes
Jan 12, 2023
BenWhitehead
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot bot
added a commit
that referenced
this pull request
Dec 5, 2023
…p/templates/java_library/.kokoro (#1846) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Burke Davison <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Co-authored-by: Alice <[email protected]> Source-Link: googleapis/synthtool@bfb4e63 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:11d59eabd49dc088f8339fb96e9da79ba4b3a73b3d49a8a4e0263e91edd053ba
sydney-munro
added a commit
that referenced
this pull request
Dec 13, 2023
…p/templates/java_library/.kokoro (#1846) (#2328) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@bfb4e63 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:11d59eabd49dc088f8339fb96e9da79ba4b3a73b3d49a8a4e0263e91edd053ba Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Burke Davison <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Co-authored-by: Alice <[email protected]> Co-authored-by: Sydney Munro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero (0) is a special value for some serialization configurations. Add a test to ensure it is properly passed to the backend, and is effective.