Skip to content

Commit

Permalink
chore: move tests which use FakeServer to be Integration Tests (#1987)
Browse files Browse the repository at this point in the history
GitHub actions seem to sometimes have issues with tcp connection's lingering longer than they should, or having things delayed. Other languages have encountered TCP issues in their actions too.

In an effort to try and reduce the likelihood of this causing build flakiness move these test which use FakeServer to be Integration tests where we haven't encountered these kinds of failures.
  • Loading branch information
BenWhitehead committed Apr 18, 2023
1 parent 5fa27f5 commit 86fbc4a
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
* <p><i>NOTE:</i>Unfortunately, these tests are slow as they are waiting on wall clock time in
* several circumstances.
*/
public final class GapicReadTimeoutTest {
public final class ITGapicReadTimeoutTest {

private final String objectName = "name";
private final Object expectedResult =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
import java.util.concurrent.atomic.AtomicInteger;
import org.junit.Test;

public final class GapicUnbufferedReadableByteChannelTest {
public final class ITGapicUnbufferedReadableByteChannelTest {
private final byte[] bytes = DataGenerator.base64Characters().genBytes(40);
private final ByteString data1 = ByteString.copyFrom(bytes, 0, 10);
private final ByteString data2 = ByteString.copyFrom(bytes, 10, 10);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@
import java.util.stream.Collectors;
import org.junit.Test;

public final class GapicUnbufferedWritableByteChannelTest {
public final class ITGapicUnbufferedWritableByteChannelTest {
private static final Logger LOGGER =
Logger.getLogger(GapicUnbufferedWritableByteChannelTest.class.getName());
Logger.getLogger(ITGapicUnbufferedWritableByteChannelTest.class.getName());

private static final ChunkSegmenter segmenter =
new ChunkSegmenter(Hasher.noop(), ByteStringStrategy.copy(), 10, 5);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import com.google.api.core.ApiFuture;
import com.google.api.gax.grpc.GrpcCallContext;
import com.google.cloud.storage.GapicUnbufferedWritableByteChannelTest.DirectWriteService;
import com.google.cloud.storage.ITGapicUnbufferedWritableByteChannelTest.DirectWriteService;
import com.google.cloud.storage.Storage.BlobTargetOption;
import com.google.cloud.storage.Storage.BlobWriteOption;
import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -50,7 +50,7 @@
* Verify some simplistic retries can take place and that we're constructing {@link
* WriteObjectRequest}s as expected.
*/
public final class GrpcStorageImplUploadRetryTest {
public final class ITGrpcStorageImplUploadRetryTest {
private static final String FORMATTED_BUCKET_NAME = "projects/_/buckets/buck";
private static final int objectContentSize = 64;
private static final byte[] bytes = DataGenerator.base64Characters().genBytes(objectContentSize);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
import org.junit.runner.RunWith;

@RunWith(Enclosed.class)
public class GzipReadableByteChannelTest {
public class ITGzipReadableByteChannelTest {

@SuppressWarnings("PointlessArithmeticExpression")
private static final int _1KiB = 1 * 1024;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
import org.junit.runner.RunWith;

@RunWith(Enclosed.class)
public final class UpdateMaskTest {
public final class ITUpdateMaskTest {

public static final class BlobInfoUpdateMask {

Expand Down

0 comments on commit 86fbc4a

Please sign in to comment.