Skip to content

Conversation

@sakthivelmanii
Copy link
Collaborator

@sakthivelmanii sakthivelmanii commented Nov 16, 2025

Description:

Due to local networking, CPU, memory there can be slight variance in performance between runs. 15% is not enough which is producing false positives. Increasing to 20% to avoid false positives.

@sakthivelmanii sakthivelmanii requested review from a team as code owners November 16, 2025 16:56
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 16, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @sakthivelmanii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update to the JMH performance benchmarking baseline. It adjusts the acceptable performance deviation for certain metrics, ensuring that the benchmark results continue to accurately reflect expected performance characteristics and tolerances.

Highlights

  • JMH Baseline Update: The JMH performance benchmarking baseline has been updated. Specifically, the acceptable 'difference' threshold for two 50th percentile metrics within the jmh-baseline.json file was increased from "15" to "20".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JMH performance benchmark baseline, increasing the allowed performance deviation from 15% to 20% for two benchmarks. This effectively accepts a performance regression. However, the pull request description lacks any justification for this change. It is crucial to document why this performance degradation is acceptable to prevent unintended, cumulative performance regressions in the future. My review includes comments highlighting this and also suggests a minor improvement to use numeric types instead of strings for numeric values in the JSON configuration for better type safety.

@sakthivelmanii sakthivelmanii merged commit 1511294 into main Nov 17, 2025
41 of 42 checks passed
@sakthivelmanii sakthivelmanii deleted the change_jmh_baseline branch November 17, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants