Skip to content

fix: getCommitResponse() should return error if tx has not committed #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

fix: getCommitResponse() should return error if tx has not committed #4021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf75c6a
fix: getCommitResponse() should return error if tx has not committed
olavloite Aug 15, 2025
06359da
Merge branch 'main' into async-tx-mgr-return-exception-on-rollback
olavloite Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncTransactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,10 @@ interface AsyncTransactionFunction<I, O> {
/** Returns the state of the transaction. */
TransactionState getState();

/** Returns the {@link CommitResponse} of this transaction. */
/**
* Returns the {@link CommitResponse} of this transaction. This method may only be called after
* committing the transaction.
*/
ApiFuture<CommitResponse> getCommitResponse();

/**
Expand Down
3 changes: 3 additions & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncTransactionManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ public TransactionState getState() {

@Override
public ApiFuture<CommitResponse> getCommitResponse() {
Preconditions.checkState(
txnState == TransactionState.COMMITTED,
"getCommitResponse can only be invoked if the transaction was successfully committed");
return commitResponse;
}

Expand Down
8 changes: 8 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncTransactionManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,14 @@ public void asyncTransactionManager_shouldRollbackOnCloseAsync() throws Exceptio
0L);
}

@Test
public void testAsyncTransactionManager_getCommitResponseReturnsErrorBeforeCommit() {
try (AsyncTransactionManager manager = client().transactionManagerAsync()) {
TransactionContextFuture transactionContextFuture = manager.beginAsync();
assertThrows(IllegalStateException.class, manager::getCommitResponse);
}
}

@Test
public void testAsyncTransactionManager_returnsCommitStats() throws Exception {
try (AsyncTransactionManager manager =
Expand Down
Loading