Skip to content

fix: add keepalives to GRPC channel #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 2 commits into from
Jan 14, 2020
Merged

fix: add keepalives to GRPC channel #11

olavloite merged 2 commits into from
Jan 14, 2020

Conversation

@allenpradeep
Copy link
Contributor

@allenpradeep allenpradeep commented Jan 6, 2020 •
edited
Loading

This patch adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. While running dataflow import jobs, issues have been observed with the spanner commit calls that run more than 10 minutes. Adding keepalives to the GRPC channel solves these issues.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2020
@allenpradeep
Merge pull request #1 from googleapis/master
c062661 
chore: update common templates (#12)
@allenpradeep
fix: add keepalives to GRPC channel
2c570fd 
This patch adds keepalives to the GRPC channel every 2 minutes. By
default, there are no keepalives to the GRPC channel. While running
dataflow import jobs, issues have been observed with the spanner
commit calls that run more than 10 minutes. Adding keepalives to
the GRPC channel solves these issues.
@allenpradeep allenpradeep changed the title Add keepalives to GRPC channel fix: add keepalives to GRPC channel Jan 7, 2020
@allenpradeep
Copy link
Contributor Author

allenpradeep commented Jan 7, 2020

@skuruppu - Can you please take a look at this.

@skuruppu skuruppu requested a review from olavloite January 9, 2020 05:03
olavloite
olavloite approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@allenpradeep
Copy link
Contributor Author

allenpradeep commented Jan 14, 2020

Hi @skuruppu,
I dont have write access to the repository. Can someone with write access merge this pull request?

@olavloite olavloite merged commit 428a4a6 into googleapis:master Jan 14, 2020
@allenpradeep
Copy link
Contributor Author

allenpradeep commented Jan 14, 2020

Thanks @olavloite

@yoshi-automation yoshi-automation mentioned this pull request Jan 14, 2020
Merged
@allenpradeep allenpradeep deleted the add_keepalive_time branch January 17, 2020 01:18
@larkee larkee mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

+2 more reviewers

@skuruppu skuruppu skuruppu approved these changes

@mbril mbril mbril approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@allenpradeep @skuruppu @olavloite @mbril @googlebot