Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new configuration necessary to support auto-value #136

Merged
merged 1 commit into from
May 19, 2020
Merged

feat: add new configuration necessary to support auto-value #136

merged 1 commit into from
May 19, 2020

Commits on May 18, 2020

  1. feat: add new configuration necessary to support auto-value

    Normally we would want to include auto-value in
    java-shared-dependencies, however auto-value includes a compiler
    extension and requires build configuration.
    
    #### Dependencies
    
    This change adds a dependencyManagement section with contains
    auto-value-annotations to manage which version of
    auto-value-annotations is used by projects and included in the
    dependency tree.
    
    #### Profiles
    
    Two new profiles have been added with the necessary
    configuration to include auto-value in the annotationProcessorPath
    when compiling.
    
    Auto value does not support java7 across all its artifacts
    consistently and requires us to have build configuration for java7
    and java8+ to deal with this fact. When we drop support for java7 the
    autovalue-java7 profile can be deleted, and the jdk based activation
    of autovalue-java8 can be removed.
    
    ##### Activation
    Activation of each of the profiles is accomplished using a combination
    of jdk version and file-exists rules. Not all modules underneath this
    shared config use auto-value and thus we don't want to modify the
    annotationProcessorPath for everything. This allows the use of
    auto-value to be opt-in per module.
    
    To use either autovalue-java* profile, create an empty file in the
    module root named `EnableAutoValue.txt`. When the maven config is
    loaded it will look for this file, and if present activate the
    respective profile based on which version of java is running.
    
    Related to: googleapis/java-shared-dependencies#37
    BenWhitehead committed May 18, 2020
    Configuration menu
    Copy the full SHA
    f8b028b View commit details
    Browse the repository at this point in the history