samples: add code snippets for Service Directory. #28

makk94 · 2020-04-02T11:04:57Z

Initially reviewed in pull request: github.com/GoogleCloudPlatform/java-docs-samples/pull/2538

These are expected to be added to go on our docs site page: cloud.google.com/service-directory/docs/configuring-service-directory

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #27 ☕️

Initially reviewed in pull request: github.com/GoogleCloudPlatform/java-docs-samples/pull/2538 These are expected to be added to go on our docs site page: cloud.google.com/service-directory/docs/configuring-service-directory

samples/snippets/src/main/java/com/example/servicedirectory/EndpointsCreate.java

samples/snippets/README.md

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/46cdbcfa-1e99-4e4f-be05-90f447630a24/targets

…uration to v1.0.15 (#29) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud.samples:shared-configuration](https://github.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.14` -> `1.0.15` | --- ### Release Notes <details> <summary>GoogleCloudPlatform/java-repo-tools</summary> ### [`v1.0.15`](https://github.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.15) [Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.14...v1.0.15) - Move some stuff around (in prep for a change to release process) pom.xml's - Add an exclude filter for SpotBugs. (disable the Java 11 surprise) - Don't fail on SpotBugs issues for now - add PMD reporting - Don't fail on PMD issues for now. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.threeten:threetenbp](https://www.threeten.org/threetenbp) ([source](https://github.com/ThreeTen/threetenbp)) | patch | `1.4.1` -> `1.4.3` | --- ### Release Notes <details> <summary>ThreeTen/threetenbp</summary> ### [`v1.4.3`](https://github.com/ThreeTen/threetenbp/releases/v1.4.3) [Compare Source](https://github.com/ThreeTen/threetenbp/compare/v1.4.2...v1.4.3) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. ### [`v1.4.2`](https://github.com/ThreeTen/threetenbp/releases/v1.4.2) [Compare Source](https://github.com/ThreeTen/threetenbp/compare/v1.4.1...v1.4.2) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

….1 (#30) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `4.4.0` -> `4.4.1` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) | minor | `1.27.2` -> `1.28.1` | | [com.google.api:gax-grpc](https://github.com/googleapis/gax-java) | minor | `1.54.0` -> `1.56.0` | | [com.google.api:gax-bom](https://github.com/googleapis/gax-java) | minor | `1.54.0` -> `1.56.0` | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.28.1`](https://github.com/grpc/grpc-java/releases/v1.28.1) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.28.0...v1.28.1) #### Bug Fixes - xds: implement more clear specifications for locality filtering (allow localities with 0 endpoint, ignore localities with 0 weight, check for locality priority continuity). ([#6875](https://github.com/grpc/grpc-java/issues/6875)) ### [`v1.28.0`](https://github.com/grpc/grpc-java/releases/v1.28.0) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.27.2...v1.28.0) #### gRPC Java 1.28.0 Release Notes #### API Changes - core: service config parsing now validates the final config object via `LoadBalancerProvider#parseLoadBalancingPolicyConfig`. LoadBalancer developers should use parsed config(`loadBalancingPolicyConfig`) in `ResolvedAddresses` instead of deprecated attribute `io.grpc.LoadBalancer.ATTR_LOAD_BALANCING_CONFIG`. - core: remove stickiness from round robin ([#6698](https://github.com/grpc/grpc-java/issues/6698)) #### Behavioral Changes - core, grpclb: change policy selection strategy for Grpclb policy (take one: eliminate special logic for deciding grpclb policy in core) ([#6637](https://github.com/grpc/grpc-java/issues/6637)) - gRPCLB policy selection is being stabilized according to [this gRFC](https://github.com/grpc/proposal/blob/master/A26-grpclb-selection.md). gRPCLB policy will not be automatically selected even if there are SRV addresses resolved. You need to explicitly specify the selection by service config (in TXT records, or via `ManagedChannelBuilder#defaultServiceConfig` or `ManagedChannelBuilder#defaultLoadBalancingPolicy`). #### New Features - This release adds an experimental client side implementation of [xDSv2](https://www.envoyproxy.io/docs/envoy/latest/api-v2/api) APIs. This allows a gRPC client written in Java to receive configuration from an xDSv2 API compatible server and use that configuration to load balance RPCs. In this release, only the virtual host matching and cluster route action is supported. More features will be added in future. #### Bug Fixes - netty: fix a deadlock on start gRPC server ([#6601](https://github.com/grpc/grpc-java/issues/6601)) - netty: negotiated application level protocol is now checked against the correct ALPN list in the SslContext settings - okhttp: fix incorrect connection-level flow control handling at beginning of connection. - alts: Fix using the wrong way of checking if Conscrypt is available ([#6672](https://github.com/grpc/grpc-java/issues/6672)) - grpclb: grpclb can handle empty address from LoadBalancer instead of throwing exception - alts: do not exclude opencensus-api from google-oauth2's transitive dependencies ([#6607](https://github.com/grpc/grpc-java/issues/6607)) - grpc-alts was broken since 1.27.0 release for missing opencensus-api used in google-oauth2. This was due to opencensus-api dependency was eliminated from grpc-core. Now it should be included. #### Documentation - stub,examples: Clarify CallStreamObserver's Javadoc ([#6561](https://github.com/grpc/grpc-java/issues/6561)) #### Dependencies - Bump Netty to 4.1.45.Final and tcnative to 2.0.28.Final - Bump okhttp to 2.7.4 - Bump google-auth-library-credentials and google-auth-library-oauth2-http to 0.20.0 #### Acknowledgements [@chrisschek](https://github.com/chrisschek) [@cushon](https://github.com/cushon) Liam Miller-Cushon [@elharo](https://github.com/elharo) Elliotte Rusty Harold [@gfelbing](https://github.com/gfelbing) Georg Welzel [@hatahet](https://github.com/hatahet) Ziad Hatahet [@leventov](https://github.com/leventov) Roman Leventov [@sourabhsparkala](https://github.com/sourabhsparkala) Sourabh Sarvotham Parkala [@ZhenLian](https://github.com/ZhenLian) Zhen Lian </details> <details> <summary>googleapis/gax-java</summary> ### [`v1.56.0`](https://github.com/googleapis/gax-java/releases/v1.56.0) [Compare Source](https://github.com/googleapis/gax-java/compare/v1.55.0...v1.56.0) 04-06-2020 10:29 PDT ##### New Features - Add ability to partially update retry settings ([#993](https://github.com/googleapis/gax-java/pull/993)) ##### Dependencies - Update grpc to 1.28.1 ([#1013](https://github.com/googleapis/gax-java/pull/1013)) - Update com.google.api:api-common to 1.9.0 ([#992](https://github.com/googleapis/gax-java/pull/992)) - Add javax.annotations dependency in bazel build to gax-grpc ([#1000](https://github.com/googleapis/gax-java/pull/1000)) ##### Internal / Testing Changes - test: make it easier to debug failures in SettingsTest ([#994](https://github.com/googleapis/gax-java/pull/994)) - build: update dependency gradle.plugin.com.dorongold.plugins:task-tree to v1.5 ([#995](https://github.com/googleapis/gax-java/pull/995)) - test: update dependency com.google.api.grpc:grpc-google-cloud-pubsub-v1 to v1.86.0 ([#1008](https://github.com/googleapis/gax-java/pull/1008)) ### [`v1.55.0`](https://github.com/googleapis/gax-java/releases/v1.55.0) [Compare Source](https://github.com/googleapis/gax-java/compare/v1.54.0...v1.55.0) 03-27-2020 08:33 PDT ##### New Features - Allow client authors to create their own callable chains ([#891](https://github.com/googleapis/gax-java/pull/891)) ##### Dependencies - Update org.threeten:threetenbp to v1.4.1 ([#890](https://github.com/googleapis/gax-java/pull/890)) ##### Internal / Testing Changes - chore(deps): update dependency com.google.api.grpc:grpc-google-cloud-bigtable-v2 to v1 ([#953](https://github.com/googleapis/gax-java/pull/953)) - chore(deps): update dependency com.google.api.grpc:grpc-google-cloud-pubsub-v1 to v1 ([#970](https://github.com/googleapis/gax-java/pull/970)) - remove unused property ([#887](https://github.com/googleapis/gax-java/pull/887)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

…irectory to v0.1.1 (#32) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-servicedirectory](https://github.com/googleapis/java-servicedirectory) | patch | `0.1.0` -> `0.1.1` | --- ### Release Notes <details> <summary>googleapis/java-servicedirectory</summary> ### [`v0.1.1`](https://github.com/googleapis/java-servicedirectory/blob/master/CHANGELOG.md#011-httpswwwgithubcomgoogleapisjava-servicedirectorycomparev010v011-2020-04-06) [Compare Source](https://github.com/googleapis/java-servicedirectory/compare/v0.1.0...v0.1.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

nnegrey · 2020-04-08T21:05:28Z

samples/snippets/src/main/java/com/example/servicedirectory/NamespacesCreate.java

+      LocationName parent = LocationName.of(projectId, locationId);
+
+      // The namespace object to create. Here, we use the default instance.
+      Namespace namespace = Namespace.newBuilder().build();


Will the default instance typically be used or is it worth showing of some of the options in the sample?

I think the default instance will be pretty typical (there's only one field in this object that I don't think is too interesting)

nnegrey · 2020-04-08T21:07:05Z

samples/snippets/src/main/java/com/example/servicedirectory/ServicesCreate.java

+      NamespaceName parent = NamespaceName.of(projectId, locationId, namespaceId);
+
+      // The service object to create. Here, we use the default instance.
+      Service service = Service.newBuilder().build();


Same question from NameSpace, default or worth showing some configuration options?

Added a little configuration

nnegrey

Few nits / questions, but LGTM

nnegrey · 2020-04-10T17:57:54Z

@chingor13, with the new repo setup, is everything in the right spot to have the tests run?

chingor13 · 2020-04-10T18:05:07Z

It should be with the exception that we're only setting the GCLOUD_PROJECT env variable instead of GOOGLE_CLOUD_PROJECT. I filed googleapis/synthtool#483 on myself to fix this in our templates, but go ahead and update the .kokoro/presubmit/samples.cfg and .kokoro/nightly/samples.cfg to use GOOGLE_CLOUD_PROJECT which is what these tests are looking for.

makk94 · 2020-04-10T18:33:13Z

It should be with the exception that we're only setting the GCLOUD_PROJECT env variable instead of GOOGLE_CLOUD_PROJECT. I filed googleapis/synthtool#483 on myself to fix this in our templates, but go ahead and update the .kokoro/presubmit/samples.cfg and .kokoro/nightly/samples.cfg to use GOOGLE_CLOUD_PROJECT which is what these tests are looking for.

When I update the .kokoro/ files, should those be part of my pull request or should I wait for your fix to go get merged first? Can the tests run if I don't add those to my PR?

Separately, it looks like your integration test project is gcloud-devrel. If this is calling our production endpoint, the Service Directory API will need to be enabled on the project. I don't have permissions to the project - can you give me permissions or go in and enable the API for me please?

gcf-merge-on-green · 2020-04-10T20:46:16Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-10T20:48:17Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-10T20:50:17Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-10T20:52:20Z

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

gcf-merge-on-green · 2020-04-10T23:50:07Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

* Add code snippets for Service Directory. Initially reviewed in pull request: github.com/GoogleCloudPlatform/java-docs-samples/pull/2538 These are expected to be added to go on our docs site page: cloud.google.com/service-directory/docs/configuring-service-directory * inline some stuff in EndpointsCreate snippet. * chore: update libraries-bom to 4.4.0 (#26) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/46cdbcfa-1e99-4e4f-be05-90f447630a24/targets * chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#29) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud.samples:shared-configuration](https://github.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.14` -> `1.0.15` | --- ### Release Notes <details> <summary>GoogleCloudPlatform/java-repo-tools</summary> ### [`v1.0.15`](https://github.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.15) [Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.14...v1.0.15) - Move some stuff around (in prep for a change to release process) pom.xml's - Add an exclude filter for SpotBugs. (disable the Java 11 surprise) - Don't fail on SpotBugs issues for now - add PMD reporting - Don't fail on PMD issues for now. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * deps: update dependency org.threeten:threetenbp to v1.4.3 (#14) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.threeten:threetenbp](https://www.threeten.org/threetenbp) ([source](https://github.com/ThreeTen/threetenbp)) | patch | `1.4.1` -> `1.4.3` | --- ### Release Notes <details> <summary>ThreeTen/threetenbp</summary> ### [`v1.4.3`](https://github.com/ThreeTen/threetenbp/releases/v1.4.3) [Compare Source](https://github.com/ThreeTen/threetenbp/compare/v1.4.2...v1.4.3) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. ### [`v1.4.2`](https://github.com/ThreeTen/threetenbp/releases/v1.4.2) [Compare Source](https://github.com/ThreeTen/threetenbp/compare/v1.4.1...v1.4.2) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#30) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `4.4.0` -> `4.4.1` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * deps: update core dependencies (#1) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) | minor | `1.27.2` -> `1.28.1` | | [com.google.api:gax-grpc](https://github.com/googleapis/gax-java) | minor | `1.54.0` -> `1.56.0` | | [com.google.api:gax-bom](https://github.com/googleapis/gax-java) | minor | `1.54.0` -> `1.56.0` | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.28.1`](https://github.com/grpc/grpc-java/releases/v1.28.1) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.28.0...v1.28.1) #### Bug Fixes - xds: implement more clear specifications for locality filtering (allow localities with 0 endpoint, ignore localities with 0 weight, check for locality priority continuity). ([#6875](https://github.com/grpc/grpc-java/issues/6875)) ### [`v1.28.0`](https://github.com/grpc/grpc-java/releases/v1.28.0) [Compare Source](https://github.com/grpc/grpc-java/compare/v1.27.2...v1.28.0) #### gRPC Java 1.28.0 Release Notes #### API Changes - core: service config parsing now validates the final config object via `LoadBalancerProvider#parseLoadBalancingPolicyConfig`. LoadBalancer developers should use parsed config(`loadBalancingPolicyConfig`) in `ResolvedAddresses` instead of deprecated attribute `io.grpc.LoadBalancer.ATTR_LOAD_BALANCING_CONFIG`. - core: remove stickiness from round robin ([#6698](https://github.com/grpc/grpc-java/issues/6698)) #### Behavioral Changes - core, grpclb: change policy selection strategy for Grpclb policy (take one: eliminate special logic for deciding grpclb policy in core) ([#6637](https://github.com/grpc/grpc-java/issues/6637)) - gRPCLB policy selection is being stabilized according to [this gRFC](https://github.com/grpc/proposal/blob/master/A26-grpclb-selection.md). gRPCLB policy will not be automatically selected even if there are SRV addresses resolved. You need to explicitly specify the selection by service config (in TXT records, or via `ManagedChannelBuilder#defaultServiceConfig` or `ManagedChannelBuilder#defaultLoadBalancingPolicy`). #### New Features - This release adds an experimental client side implementation of [xDSv2](https://www.envoyproxy.io/docs/envoy/latest/api-v2/api) APIs. This allows a gRPC client written in Java to receive configuration from an xDSv2 API compatible server and use that configuration to load balance RPCs. In this release, only the virtual host matching and cluster route action is supported. More features will be added in future. #### Bug Fixes - netty: fix a deadlock on start gRPC server ([#6601](https://github.com/grpc/grpc-java/issues/6601)) - netty: negotiated application level protocol is now checked against the correct ALPN list in the SslContext settings - okhttp: fix incorrect connection-level flow control handling at beginning of connection. - alts: Fix using the wrong way of checking if Conscrypt is available ([#6672](https://github.com/grpc/grpc-java/issues/6672)) - grpclb: grpclb can handle empty address from LoadBalancer instead of throwing exception - alts: do not exclude opencensus-api from google-oauth2's transitive dependencies ([#6607](https://github.com/grpc/grpc-java/issues/6607)) - grpc-alts was broken since 1.27.0 release for missing opencensus-api used in google-oauth2. This was due to opencensus-api dependency was eliminated from grpc-core. Now it should be included. #### Documentation - stub,examples: Clarify CallStreamObserver's Javadoc ([#6561](https://github.com/grpc/grpc-java/issues/6561)) #### Dependencies - Bump Netty to 4.1.45.Final and tcnative to 2.0.28.Final - Bump okhttp to 2.7.4 - Bump google-auth-library-credentials and google-auth-library-oauth2-http to 0.20.0 #### Acknowledgements [@chrisschek](https://github.com/chrisschek) [@cushon](https://github.com/cushon) Liam Miller-Cushon [@elharo](https://github.com/elharo) Elliotte Rusty Harold [@gfelbing](https://github.com/gfelbing) Georg Welzel [@hatahet](https://github.com/hatahet) Ziad Hatahet [@leventov](https://github.com/leventov) Roman Leventov [@sourabhsparkala](https://github.com/sourabhsparkala) Sourabh Sarvotham Parkala [@ZhenLian](https://github.com/ZhenLian) Zhen Lian </details> <details> <summary>googleapis/gax-java</summary> ### [`v1.56.0`](https://github.com/googleapis/gax-java/releases/v1.56.0) [Compare Source](https://github.com/googleapis/gax-java/compare/v1.55.0...v1.56.0) 04-06-2020 10:29 PDT ##### New Features - Add ability to partially update retry settings ([#993](https://github.com/googleapis/gax-java/pull/993)) ##### Dependencies - Update grpc to 1.28.1 ([#1013](https://github.com/googleapis/gax-java/pull/1013)) - Update com.google.api:api-common to 1.9.0 ([#992](https://github.com/googleapis/gax-java/pull/992)) - Add javax.annotations dependency in bazel build to gax-grpc ([#1000](https://github.com/googleapis/gax-java/pull/1000)) ##### Internal / Testing Changes - test: make it easier to debug failures in SettingsTest ([#994](https://github.com/googleapis/gax-java/pull/994)) - build: update dependency gradle.plugin.com.dorongold.plugins:task-tree to v1.5 ([#995](https://github.com/googleapis/gax-java/pull/995)) - test: update dependency com.google.api.grpc:grpc-google-cloud-pubsub-v1 to v1.86.0 ([#1008](https://github.com/googleapis/gax-java/pull/1008)) ### [`v1.55.0`](https://github.com/googleapis/gax-java/releases/v1.55.0) [Compare Source](https://github.com/googleapis/gax-java/compare/v1.54.0...v1.55.0) 03-27-2020 08:33 PDT ##### New Features - Allow client authors to create their own callable chains ([#891](https://github.com/googleapis/gax-java/pull/891)) ##### Dependencies - Update org.threeten:threetenbp to v1.4.1 ([#890](https://github.com/googleapis/gax-java/pull/890)) ##### Internal / Testing Changes - chore(deps): update dependency com.google.api.grpc:grpc-google-cloud-bigtable-v2 to v1 ([#953](https://github.com/googleapis/gax-java/pull/953)) - chore(deps): update dependency com.google.api.grpc:grpc-google-cloud-pubsub-v1 to v1 ([#970](https://github.com/googleapis/gax-java/pull/970)) - remove unused property ([#887](https://github.com/googleapis/gax-java/pull/887)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * chore: release 0.1.1 (#23) :robot: I have created a release \*beep\* \*boop\* --- ### [0.1.1](https://www.github.com/googleapis/java-servicedirectory/compare/v0.1.0...v0.1.1) (2020-04-06) ### Dependencies * update core dependencies ([#1](https://www.github.com/googleapis/java-servicedirectory/issues/1)) ([a6b5a40](https://www.github.com/googleapis/java-servicedirectory/commit/a6b5a40a93d1ad2fe7865b6d284bab6c7adb6692)) * update dependency com.google.api:api-common to v1.9.0 ([#22](https://www.github.com/googleapis/java-servicedirectory/issues/22)) ([a7a8938](https://www.github.com/googleapis/java-servicedirectory/commit/a7a89380580ace369d535d6321cea716f3783105)) * update dependency org.threeten:threetenbp to v1.4.3 ([#14](https://www.github.com/googleapis/java-servicedirectory/issues/14)) ([017312e](https://www.github.com/googleapis/java-servicedirectory/commit/017312ec13e45e3fed02d90ed64a56e8a99a64e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore(deps): update dependency com.google.cloud:google-cloud-servicedirectory to v0.1.1 (#32) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-servicedirectory](https://github.com/googleapis/java-servicedirectory) | patch | `0.1.0` -> `0.1.1` | --- ### Release Notes <details> <summary>googleapis/java-servicedirectory</summary> ### [`v0.1.1`](https://github.com/googleapis/java-servicedirectory/blob/master/CHANGELOG.md#011-httpswwwgithubcomgoogleapisjava-servicedirectorycomparev010v011-2020-04-06) [Compare Source](https://github.com/googleapis/java-servicedirectory/compare/v0.1.0...v0.1.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * chore: release 0.1.2-SNAPSHOT (#33) :robot: I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v0.5.0 (#35) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-shared-config](https://github.com/googleapis/java-shared-config) | minor | `0.4.0` -> `0.5.0` | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v0.5.0`](https://github.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#050-httpswwwgithubcomgoogleapisjava-shared-configcomparev040v050-2020-04-07) [Compare Source](https://github.com/googleapis/java-shared-config/compare/v0.4.0...v0.5.0) ##### Features - add ban duplicate classes rule ([#126](https://www.github.com/googleapis/java-shared-config/issues/126)) ([e38a7cc](https://www.github.com/googleapis/java-shared-config/commit/e38a7cc949396f8f5696e62cd060e0c076047b8d)) - add devsite javadoc profile ([#121](https://www.github.com/googleapis/java-shared-config/issues/121)) ([7f452fb](https://www.github.com/googleapis/java-shared-config/commit/7f452fb6c5704f6ce0f731085479a28fb99ebcb9)) - add maven flatten plugin ([#127](https://www.github.com/googleapis/java-shared-config/issues/127)) ([fb00799](https://www.github.com/googleapis/java-shared-config/commit/fb00799c416d324d68da5b660a26f7ef595c26d9)) ##### Bug Fixes - declare com.coveo:fmt-maven-plugin version/configuration ([#90](https://www.github.com/googleapis/java-shared-config/issues/90)) ([5cf71a6](https://www.github.com/googleapis/java-shared-config/commit/5cf71a6ed699907082756e70c2fdee6ad3632f38)) ##### Dependencies - update dependency com.google.cloud.samples:shared-configuration to v1.0.13 ([#118](https://www.github.com/googleapis/java-shared-config/issues/118)) ([58ae69e](https://www.github.com/googleapis/java-shared-config/commit/58ae69eb5ba037963cdaed0c2b0e30663bc873eb)) - update dependency com.puppycrawl.tools:checkstyle to v8.29 ([f62292d](https://www.github.com/googleapis/java-shared-config/commit/f62292dab75699a75f8a7d499fe2ccfb7ee93783)) - update dependency org.apache.maven.plugins:maven-antrun-plugin to v1.8 ([#124](https://www.github.com/googleapis/java-shared-config/issues/124)) ([a681536](https://www.github.com/googleapis/java-shared-config/commit/a68153643400c3f3b5c5959cda4dc3b552336427)) - update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.1.2 ([#107](https://www.github.com/googleapis/java-shared-config/issues/107)) ([c9b096b](https://www.github.com/googleapis/java-shared-config/commit/c9b096b81b1f4f8dc2d1302f259f0321722e1ca5)) - update dependency org.apache.maven.plugins:maven-site-plugin to v3.9.0 ([#103](https://www.github.com/googleapis/java-shared-config/issues/103)) ([abe7140](https://www.github.com/googleapis/java-shared-config/commit/abe714060e858c70a83888fb34438c45d97b1168)) - update dependency org.codehaus.mojo:build-helper-maven-plugin to v3.1.0 ([#101](https://www.github.com/googleapis/java-shared-config/issues/101)) ([ac69572](https://www.github.com/googleapis/java-shared-config/commit/ac69572be76e4462fdf65fa6e7f0935c3d51d827)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory). * Fix type in README. * Add clarifying comments. Add some configuration in ServicesCreate Co-authored-by: Yoshi Automation Bot <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Source-Author: Mahina Kaholokula <[email protected]> Source-Date: Wed Apr 15 17:33:50 2020 -0400 Source-Repo: googleapis/java-servicedirectory Source-Sha: 55626b4 Source-Link: 55626b4

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/a8b4de14-bbed-43a8-a032-34b2812821a8/targets

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020

makk94 mentioned this pull request Apr 2, 2020

Add java samples for Service Directory GoogleCloudPlatform/java-docs-samples#2538

Closed

4 tasks

nnegrey reviewed Apr 2, 2020

View reviewed changes

samples/snippets/src/main/java/com/example/servicedirectory/EndpointsCreate.java Outdated Show resolved Hide resolved

nnegrey reviewed Apr 2, 2020

View reviewed changes

samples/snippets/src/main/java/com/example/servicedirectory/EndpointsCreate.java Show resolved Hide resolved

nnegrey reviewed Apr 2, 2020

View reviewed changes

samples/snippets/src/main/java/com/example/servicedirectory/EndpointsCreate.java Show resolved Hide resolved

inline some stuff in EndpointsCreate snippet.

98d371f

mdeloria reviewed Apr 3, 2020

View reviewed changes

samples/snippets/README.md Outdated Show resolved Hide resolved

yoshi-automation and others added 10 commits April 8, 2020 06:41

chore: update libraries-bom to 4.4.0 (#26)

207ed6b

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/46cdbcfa-1e99-4e4f-be05-90f447630a24/targets

chore: release 0.1.2-SNAPSHOT (#33)

5c99182

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Fix type in README.

dedd57d

nnegrey reviewed Apr 8, 2020

View reviewed changes

nnegrey approved these changes Apr 8, 2020

View reviewed changes

Mahina Kaholokula and others added 2 commits April 9, 2020 05:48

Add clarifying comments. Add some configuration in ServicesCreate

aa2efb9

Merge branch 'master' into add-servicedirectory-snippets

8f2256a

nnegrey added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2020

chingor13 changed the title ~~Add code snippets for Service Directory.~~ samples: add code snippets for Service Directory. Apr 13, 2020

chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 13, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020

chingor13 approved these changes Apr 15, 2020

View reviewed changes

chingor13 merged commit 55626b4 into googleapis:master Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: add code snippets for Service Directory. #28

samples: add code snippets for Service Directory. #28

makk94 commented Apr 2, 2020

nnegrey Apr 8, 2020

makk94 Apr 9, 2020

nnegrey Apr 8, 2020

makk94 Apr 9, 2020

nnegrey left a comment

nnegrey commented Apr 10, 2020

chingor13 commented Apr 10, 2020

makk94 commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

samples: add code snippets for Service Directory. #28

samples: add code snippets for Service Directory. #28

Conversation

makk94 commented Apr 2, 2020

nnegrey Apr 8, 2020

Choose a reason for hiding this comment

makk94 Apr 9, 2020

Choose a reason for hiding this comment

nnegrey Apr 8, 2020

Choose a reason for hiding this comment

makk94 Apr 9, 2020

Choose a reason for hiding this comment

nnegrey left a comment

Choose a reason for hiding this comment

nnegrey commented Apr 10, 2020

chingor13 commented Apr 10, 2020

makk94 commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020

gcf-merge-on-green bot commented Apr 10, 2020