Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

fix (samples) Import user events BQ, missing UpdateUserEventsJson.java #494

Conversation

dfirova
Copy link
Contributor

@dfirova dfirova commented Jul 18, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@dfirova dfirova requested review from a team as code owners July 18, 2022 12:11
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Jul 18, 2022
@shubha-rajan shubha-rajan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2022
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 8, 2022
@dfirova dfirova requested a review from a team as a code owner August 8, 2022 18:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 8, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2022
@alicejli
Copy link

alicejli commented Aug 9, 2022

Should there be some comments in the file explaining what UpdateUserEventsJson.java is for? I noticed none of the files in java-retail/samples/interactive-tutorials/src/main/java/events/setup/ have comments, so perhaps it's not needed; I'm not familiar with what these are for.

@dfirova
Copy link
Contributor Author

dfirova commented Aug 11, 2022

Should there be some comments in the file explaining what UpdateUserEventsJson.java is for? I noticed none of the files in java-retail/samples/interactive-tutorials/src/main/java/events/setup/ have comments, so perhaps it's not needed; I'm not familiar with what these are for.

As all the other files in setup don't contain description, the correct way of resolving it, in my opinion, would be adding all the descriptions in a separate task (PR), if the decision is made to do so.

Copy link

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay that makes sense to me. Will file an issue against this repo to do so in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants