Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 28, 2023

This intends to fix issue in googleapis/java-cloud-bom#6050 (comment)
dependency tree for j2objc-annotations without this fix:

[INFO] --------------< com.google.cloud:google-cloud-pubsublite >--------------
[INFO] Building Google Cloud Pub/Sub Lite 1.12.10-SNAPSHOT                [4/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ google-cloud-pubsublite ---
[INFO] com.google.cloud:google-cloud-pubsublite:jar:1.12.10-SNAPSHOT
[INFO] \- com.google.cloud:google-cloud-pubsub:jar:1.123.14:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:1.3:compile

After this fix:

[INFO] --------------< com.google.cloud:google-cloud-pubsublite >--------------
[INFO] Building Google Cloud Pub/Sub Lite 1.12.10-SNAPSHOT                [4/5]
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-pubsub/1.123.17/google-cloud-pubsub-1.123.17.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-pubsub/1.123.17/google-cloud-pubsub-1.123.17.pom (36 kB at 102 kB/s)
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ google-cloud-pubsublite ---
[INFO] com.google.cloud:google-cloud-pubsublite:jar:1.12.10-SNAPSHOT
[INFO] \- com.google.cloud:google-cloud-pubsub:jar:1.123.17:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 

@zhumin8 zhumin8 requested review from a team as code owners June 28, 2023 00:44
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Jun 28, 2023
@zhumin8 zhumin8 requested a review from suztomo June 28, 2023 00:45
@zhumin8 zhumin8 merged commit a500c18 into main Jun 28, 2023
@zhumin8 zhumin8 deleted the fix-versions branch June 28, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants