Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample): remove no-server build arg #1165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mukamik
Copy link

@Mukamik Mukamik commented Jun 14, 2022

Proposing this change since no-server is now enabled by default, and I got a warning that this flag is being ignored during the build.

For context, I got the warning when building on cloud shell with Graal 22.0.0.2-r17.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Proposing this change since [no-server](oracle/graal#2598) is now enabled by default, and I got a warning that this flag is being ignored during the build.

For context, I got the warning when building on cloud shell with Graal 22.0.0.2-r17.
@Mukamik Mukamik requested review from a team as code owners June 14, 2022 15:27
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jun 14, 2022
@eaball35 eaball35 assigned meltsufin and unassigned eaball35 Jul 11, 2022
@mpeddada1 mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2022
@meltsufin meltsufin removed their assignment May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants