Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove @BetaApi annotations from get/setDatabaseId methods #1272

Merged
merged 1 commit into from
Jan 3, 2024
Merged

feat: remove @BetaApi annotations from get/setDatabaseId methods #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions google-cloud-datastore/src/main/java/com/google/cloud/datastore/BaseKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import static com.google.cloud.datastore.Validator.validateNamespace;
import static com.google.cloud.datastore.Validator.validateProjectId;

import com.google.api.core.BetaApi;
import com.google.common.base.MoreObjects;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -117,7 +116,6 @@ public B setNamespace(String namespace) {
}

/** Sets the database id of the key. */
@BetaApi
public B setDatabaseId(String databaseId) {
this.databaseId = databaseId;
return self();
Expand Down Expand Up @@ -148,7 +146,6 @@ public String getNamespace() {
return namespace;
}

@BetaApi
public String getDatabaseId() {
return databaseId;
}
Expand Down
3 changes: 0 additions & 3 deletions google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import static com.google.cloud.datastore.Validator.validateNamespace;

import com.google.api.core.BetaApi;
import com.google.cloud.ServiceDefaults;
import com.google.cloud.ServiceOptions;
import com.google.cloud.ServiceRpc;
Expand Down Expand Up @@ -97,7 +96,6 @@ public Builder setNamespace(String namespace) {
return this;
}

@BetaApi
public Builder setDatabaseId(String databaseId) {
this.databaseId = databaseId;
return this;
Expand Down Expand Up @@ -155,7 +153,6 @@ public String getNamespace() {
return namespace;
}

@BetaApi
public String getDatabaseId() {
return this.databaseId;
}
Expand Down
2 changes: 0 additions & 2 deletions google-cloud-datastore/src/main/java/com/google/cloud/datastore/IncompleteKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.datastore;

import com.google.api.core.BetaApi;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import java.util.List;
Expand Down Expand Up @@ -107,7 +106,6 @@ public static Builder newBuilder(String projectId, String kind) {
return new Builder(projectId, kind);
}

@BetaApi
public static Builder newBuilderWithDatabaseId(String projectId, String kind, String databaseId) {
return new Builder(projectId, kind, databaseId);
}
Expand Down
3 changes: 0 additions & 3 deletions google-cloud-datastore/src/main/java/com/google/cloud/datastore/Key.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import static java.nio.charset.StandardCharsets.UTF_8;

import com.google.api.core.BetaApi;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.protobuf.TextFormat;
Expand Down Expand Up @@ -180,7 +179,6 @@ public static Builder newBuilder(String projectId, String kind, String name) {
return new Builder(projectId, kind, name);
}

@BetaApi
public static Builder newBuilder(String projectId, String kind, String name, String databaseId) {
return new Builder(projectId, kind, name, databaseId);
}
Expand All @@ -189,7 +187,6 @@ public static Builder newBuilder(String projectId, String kind, long id) {
return new Builder(projectId, kind, id);
}

@BetaApi
public static Builder newBuilder(String projectId, String kind, long id, String databaseId) {
return new Builder(projectId, kind, id, databaseId);
}
Expand Down
2 changes: 0 additions & 2 deletions google-cloud-datastore/src/main/java/com/google/cloud/datastore/KeyFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.datastore;

import com.google.api.core.BetaApi;
import com.google.common.collect.ImmutableList;

/**
Expand All @@ -37,7 +36,6 @@ public KeyFactory(String projectId, String namespace) {
this(projectId, namespace, "");
}

@BetaApi
public KeyFactory(String projectId, String namespace, String databaseId) {
super(projectId);
setNamespace(namespace);
Expand Down
2 changes: 0 additions & 2 deletions ...oud-datastore/src/main/java/com/google/cloud/datastore/testing/RemoteDatastoreHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.datastore.testing;

import com.google.api.core.BetaApi;
import com.google.api.core.InternalApi;
import com.google.api.gax.retrying.RetrySettings;
import com.google.cloud.datastore.Datastore;
Expand Down Expand Up @@ -79,7 +78,6 @@ public static RemoteDatastoreHelper create() {
}

/** Creates a {@code RemoteStorageHelper} object. */
@BetaApi
public static RemoteDatastoreHelper create(String databaseId) {
HttpTransportOptions transportOptions = DatastoreOptions.getDefaultHttpTransportOptions();
transportOptions =
Expand Down