Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make version embedding more robust #451

Merged
merged 3 commits into from
Oct 16, 2020
Merged

chore: make version embedding more robust #451

merged 3 commits into from
Oct 16, 2020

Commits on Oct 8, 2020

  1. chore: make version embedding more robust 

    The previous approach used the jar manifest. Unfortunately that approaches falls apart when the
consumer shades the client jar. The new approach uses a combination of releasetool's version tag
replacement and maven-resources-plugin to generate a class with an embedded version string.
    @igorbernstein2
    igorbernstein2 committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f6dd067 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Simplify by using a file allowlisted in release-tool

    @igorbernstein2
    igorbernstein2 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    22d831c View commit details
    Browse the repository at this point in the history

  2. Revert "Simplify by using a file allowlisted in release-tool" 

    This reverts commit 22d831c.
    @igorbernstein2
    igorbernstein2 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    cccd64c View commit details
    Browse the repository at this point in the history