-
Notifications
You must be signed in to change notification settings - Fork 101
feat(large-row-skip): added large-row-skip-callable with configurable rowadapter #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 4 commits into
googleapis:main
from
sarthakbhutani:large-row-skip-additional-work
Mar 11, 2025
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1361,6 +1361,43 @@ public <RowT> ServerStreamingCallable<Query, RowT> readRowsCallable(RowAdapter<R | |
| return stub.createReadRowsCallable(rowAdapter); | ||
| } | ||
|
|
||
| /** | ||
| * Streams back the results of the query. This callable allows for customization of the logical | ||
| * representation of a row. It's meant for advanced use cases. | ||
|
||
| * | ||
| * <p>Sample code: | ||
| * | ||
| * <pre>{@code | ||
| * try (BigtableDataClient bigtableDataClient = BigtableDataClient.create("[PROJECT]", "[INSTANCE]")) { | ||
| * String tableId = "[TABLE]"; | ||
| * | ||
| * Query query = Query.create(tableId) | ||
| * .range("[START KEY]", "[END KEY]") | ||
| * .filter(FILTERS.qualifier().regex("[COLUMN PREFIX].*")); | ||
| * | ||
| * // Iterator style | ||
| * try { | ||
| * for(CustomRow row : bigtableDataClient.skipLargeRowsCallable(new CustomRowAdapter()).call(query)) { | ||
| * // Do something with row | ||
| * } | ||
| * } catch (NotFoundException e) { | ||
| * System.out.println("Tried to read a non-existent table"); | ||
| * } catch (RuntimeException e) { | ||
| * e.printStackTrace(); | ||
| * } | ||
| * } | ||
| * }</pre> | ||
| * | ||
| * @see ServerStreamingCallable For call styles. | ||
| * @see Query For query options. | ||
| * @see com.google.cloud.bigtable.data.v2.models.Filters For the filter building DSL. | ||
| */ | ||
| @InternalApi("only to be used by Bigtable beam connector") | ||
| public <RowT> ServerStreamingCallable<Query, RowT> skipLargeRowsCallable( | ||
| RowAdapter<RowT> rowAdapter) { | ||
| return stub.createSkipLargeRowsCallable(rowAdapter); | ||
| } | ||
|
|
||
| /** | ||
| * Convenience method to synchronously return a sample of row keys in the table. The returned row | ||
| * keys will delimit contiguous sections of the table of approximately equal size, which can be | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that this skips large rows