Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing call to EqualsTester#testEquals #2292

Closed
cushon opened this issue Jul 25, 2024 · 0 comments · Fixed by #2307
Closed

Missing call to EqualsTester#testEquals #2292

cushon opened this issue Jul 25, 2024 · 0 comments · Fixed by #2307
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.

Comments

@cushon
Copy link
Contributor

cushon commented Jul 25, 2024

cc @jackdingilian

The use of EqualsTester added in 25218e8 is incorrect:

new EqualsTester()
.addEqualityGroup(
StructWithSchema.fromProto(structProto.getStructType()),
StructWithSchema.fromProto(structProto.getStructType()))
.addEqualityGroup(
StructWithSchema.fromProto(complexStructProto.getStructType()),
StructWithSchema.fromProto(complexStructProto.getStructType()));

There needs to be a terminal call to testEquals() for the equals tester to do anything, that assertion is not currently being run.

This issue was found by https://errorprone.info/bugpattern/MissingTestCall

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jul 25, 2024
cushon added a commit to cushon/java-bigtable that referenced this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant