-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set policy tags to empty instead of null #545
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
=========================================
Coverage 81.49% 81.49%
Complexity 1226 1226
=========================================
Files 77 77
Lines 6220 6221 +1
Branches 691 691
=========================================
+ Hits 5069 5070 +1
Misses 792 792
Partials 359 359
Continue to review full report at Codecov.
|
When BigQuery returns policy tag object without names, policy tags will have names field set to null (instead of the policy tags object itself set to null) to be consistent with the REST api.
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for the submission. However, the backend service response is also being corrected so that it doesn't provide the empty message for policyTags, which is the behavior the first PR mirrors. In this case, I'm going to recommend that we don't move forward with this PR. |
closing per @shollyman comment |
the reason for suggesting this change was so that we can tell the difference between the following scenarios:
it mirrors the behaviour of the description field:
we value this granularity. whats the reason for removing it? |
If you want awareness of this kind of change, then I'd suggest something like the BigQuery audit log feature. If it doesn't convey the information you need, then I'd suggest making a request on the public issue tracker or via support channels. |
Currently when BigQuery returns policy tag object without names, the whole policy tag field is set to null, which is not consistent with the REST Api, this pull request changes the behaviour to return an instance with names set to null instead.
This change modifies a previous PR #522, that was created in response to my GCP support ticket, slightly tweaking the behaviour to make it more consistent with the REST api.
Make sure to open an issue as a bug/issue before writing your code!There is GCP issue instead. The case Id is 24194276Appropriate docs were updated(if necessary)