Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max staleness to ExternalTableDefinition #3499

Merged
merged 4 commits into from
Oct 1, 2024
Merged

feat: add max staleness to ExternalTableDefinition #3499

merged 4 commits into from
Oct 1, 2024
+44 −2

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Sep 26, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 26, 2024
@PhongChuong PhongChuong marked this pull request as ready for review September 27, 2024 13:00
@PhongChuong PhongChuong requested a review from a team as a code owner September 27, 2024 13:00
whuffman36
whuffman36 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhongChuong PhongChuong merged commit f1ebd5b into main Oct 1, 2024
17 checks passed
@PhongChuong PhongChuong deleted the maxStaleness branch October 1, 2024 17:58
@PhongChuong
Copy link
Contributor Author

Thanks for the review.

@release-please release-please bot mentioned this pull request Oct 1, 2024
Merged
This was referenced Oct 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whuffman36 whuffman36 whuffman36 approved these changes

@agrawal-siddharth agrawal-siddharth Awaiting requested review from agrawal-siddharth agrawal-siddharth is a code owner automatically assigned from googleapis/api-bigquery

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhongChuong @whuffman36