-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpResponse uses contains where it needs equals #842
Labels
good first issue
This issue is a good place to started contributing to this repository.
help wanted
We'd love to have community involvement on this issue.
priority: p2
Moderately-important priority. Fix may not be included in next release.
semver: patch
A minor bug fix or small change.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
elharo
added
good first issue
This issue is a good place to started contributing to this repository.
help wanted
We'd love to have community involvement on this issue.
priority: p2
Moderately-important priority. Fix may not be included in next release.
semver: patch
A minor bug fix or small change.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
labels
Oct 14, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 14, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 19, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 20, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 27, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 27, 2019
egsavage
added a commit
to egsavage/google-http-java-client
that referenced
this issue
Oct 29, 2019
chingor13
pushed a commit
that referenced
this issue
Oct 29, 2019
* Issue #842 - HttpResponse GZip content encoding equality change * Issue #842 - Added unit test, PR updates * Issue #842 - Adjusted spacing, dropped ignoreCase on comparison * Issue #842 - Enforce locale on encoding comparison, add unit tests * Issue #842 - Removed final, fixed spelling * Issue #842 - test updates
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this issue
Aug 11, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://github.com/actions/github-script) | action | major | `v3` -> `v5` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v5`](https://github.com/actions/github-script/compare/v4...v5) [Compare Source](https://github.com/actions/github-script/compare/v4...v5) ### [`v4`](https://github.com/actions/github-script/compare/v3...v4) [Compare Source](https://github.com/actions/github-script/compare/v3...v4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
This issue is a good place to started contributing to this repository.
help wanted
We'd love to have community involvement on this issue.
priority: p2
Moderately-important priority. Fix may not be included in next release.
semver: patch
A minor bug fix or small change.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
"contains" is incorrect. This should be equals or perhaps equalsIgnoreCase with a trim, or something like that. However it shouldn't fire on foogzipbar.
The text was updated successfully, but these errors were encountered: