feat(generator): support loading proto mixins #256
Conversation
| return err | ||
| } | ||
| // Set the source package. We should always take the first service registered | ||
| // as the source package. Services with mixes well register those after the |
There was a problem hiding this comment.
This works well for mixins, but I am not sure is great to safely handle any source directory. Recall that protobuf inputs are specified as directories, and all the files in the directory are provided to the parser:
With this change, if I accidentally provide google/cloud/ as the input sidekick will try to generate something. I am not sure that is what we want.
| api.Messages = append(api.Messages, msg) | ||
| } else { | ||
| slog.Warn("missing message in symbol table", "message", mFQN) | ||
| if !isMixinPackage(f.GetPackage()) { |
There was a problem hiding this comment.
I would have said
if isMixinPackage(f.GetPackage()) {
continue;
}| "-codec-option", "package:gtype=package=type-golden-gclient,path=generator/testdata/rust/gclient/golden/type,source=google.type", | ||
| }, | ||
| }, | ||
| // { |
There was a problem hiding this comment.
Looks like a remnant of a local testing trick?
| @@ -26,6 +26,8 @@ use gax::error::{Error, HttpError}; | |||
| use google_cloud_auth::{Credential, CredentialConfig}; | |||
| use std::sync::Arc; | |||
|
|
|||
| const DEFAULT_HOST: &str = "https://{{DefaultHost}}/"; | |||
There was a problem hiding this comment.
This change seems unrelated. Nice change, but maybe should have its own PR. Ditto for the client.go.mustache change.
| var enabledMixins = map[string]bool{ | ||
| locationPackage: false, | ||
| iamPackage: false, | ||
| longrunningService: false, | ||
| } |
There was a problem hiding this comment.
This should be a property of the API.
Eventually we may want to run multiple Codec / parsers in the same sidekick instance (e.g. to regenerate the world using multiple goroutines).
No description provided.