Allowing over-ride for lock used in publisher client. #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| batches. You may subclass the | ||
| :class:`.pubsub_v1.publisher.batch.base.BaseBatch` class in | ||
| order to define your own batcher. This is primarily provided to | ||
| allow use of different concurrency models; the default | ||
| is based on :class:`threading.Thread`. | ||
| batch_lock (Optional[Any]): A lock used to ensure atomic modifications |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Dec 19, 2017
dhermes
force-pushed
the
pubsub-custom-lock
branch
from
ea6d30f
to
265d900
Compare
dhermes
force-pushed
the
pubsub-custom-lock
branch
from
265d900
to
b00c63a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3890.