Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: rename name field of Dataset to dataset_id #3955

Merged
merged 3 commits into from
Sep 14, 2017
Merged

bigquery: rename name field of Dataset to dataset_id #3955

merged 3 commits into from
Sep 14, 2017

Commits on Sep 14, 2017

  1. bigquery: rename name field of Dataset to dataset_id 

    Rename the former dataset_id property to full_dataset_id.

Also rename Table.dataset_name to Table.dataset_id.

Perform other renamings (of various variables and constants).

These names match usage better. The API's Dataset.id field is
"project:dataset_id", which is confusing and basically useless,
so it's a mistake to call that dataset_id.
    @jba
    jba committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    a431e52 View commit details
    Browse the repository at this point in the history

  2. fix long line

    @jba
    jba committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    c239602 View commit details
    Browse the repository at this point in the history

  3. fix long line

    @jba
    jba committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    6054c3b View commit details
    Browse the repository at this point in the history