Skip to content

Delete demo keys, update demos to use same environment vars as regressions #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 3 commits into from
Nov 24, 2014
Merged

Delete demo keys, update demos to use same environment vars as regressions #383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c22c34
Delete demo keys, update demos to use same environment vars as regres…
tseaver Nov 24, 2014
48c50d1
Fix names exported by '__all__'.
tseaver Nov 24, 2014
73885a3
Update docs on running demo to explain environment variables.
tseaver Nov 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions gcloud/datastore/demo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

__all__ = ['get_dataset', 'CLIENT_EMAIL', 'DATASET_ID', 'PRIVATE_KEY_PATH']

CLIENT_EMAIL = ('754762820716-gimou6egs2hq1rli7el2t621a1b04t9i'
'@developer.gserviceaccount.com')
DATASET_ID = 'gcloud-datastore-demo'
PRIVATE_KEY_PATH = os.path.join(os.path.dirname(__file__), 'demo.key')

DATASET_ID = os.getenv('GCLOUD_TESTS_DATASET_ID')

This comment was marked as spam.

Sign in to view

CLIENT_EMAIL = os.getenv('GCLOUD_TESTS_CLIENT_EMAIL')
KEY_FILENAME = os.getenv('GCLOUD_TESTS_KEY_FILE')


def get_dataset(): # pragma NO COVER
return datastore.get_dataset(DATASET_ID, CLIENT_EMAIL, PRIVATE_KEY_PATH)
return datastore.get_dataset(DATASET_ID, CLIENT_EMAIL, KEY_FILENAME)
Binary file removed gcloud/datastore/demo/demo.key
View file
Open in desktop
Binary file not shown.
9 changes: 4 additions & 5 deletions gcloud/storage/demo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@

__all__ = ['get_connection', 'CLIENT_EMAIL', 'PRIVATE_KEY_PATH', 'PROJECT']

CLIENT_EMAIL = ('606734090113-6ink7iugcv89da9sru7lii8bs3i0obqg@'
'developer.gserviceaccount.com')
PRIVATE_KEY_PATH = os.path.join(os.path.dirname(__file__), 'demo.key')
PROJECT = 'gcloud-storage-demo'
PROJECT_ID = os.getenv('GCLOUD_TESTS_PROJECT_ID')
CLIENT_EMAIL = os.getenv('GCLOUD_TESTS_CLIENT_EMAIL')
KEY_FILENAME = os.getenv('GCLOUD_TESTS_KEY_FILE')


def get_connection(): # pragma NO COVER.
return storage.get_connection(PROJECT, CLIENT_EMAIL, PRIVATE_KEY_PATH)
return storage.get_connection(PROJECT_ID, CLIENT_EMAIL, KEY_FILENAME)
Binary file removed gcloud/storage/demo/demo.key
View file
Open in desktop
Binary file not shown.