Document deepcopy semantics of complex bucket properties. #3712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'cors', 'labels', and 'lifecycle_rules' all return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter. Closes #3710
googlebot
added
the
cla: yes
dhermes
approved these changes
Aug 1, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM but I'll let @jonparrott have final say
theacodes
approved these changes
Aug 1, 2017
Contributor
Author
|
Merging w/o waiting for slow CI because this is a docstring-only change, and I've verified that docs build locally. |
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
…#3712) 'cors', 'labels', and 'lifecycle_rules' all return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter. Closes googleapis#3710
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…#3712) 'cors', 'labels', and 'lifecycle_rules' all return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter. Closes googleapis#3710
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
…#3712) 'cors', 'labels', and 'lifecycle_rules' all return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter. Closes googleapis#3710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cors,labels, andlifecycle_rulesall return copies of the values: changes to them have no effect until the copy is reassigned via the property's setter.Closes #3710