Skip to content

#370: Avoid extra URL-quoting of key name on upload. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Nov 12, 2014
Merged

#370: Avoid extra URL-quoting of key name on upload. #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcloud/storage/key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def upload_from_file(self, file_obj, rewind=False, size=None,

query_params = {
'uploadType': 'resumable',
'name': urllib.quote_plus(self.name),
'name': self.name,
}

upload_url = self.connection.build_api_url(
Expand Down
2 changes: 1 addition & 1 deletion gcloud/storage/test_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def test_upload_from_file_w_slash_in_name(self):
self.assertEqual(netloc, 'example.com')
self.assertEqual(path, '/b/name/o')
self.assertEqual(dict(parse_qsl(qs)),
{'uploadType': 'resumable', 'name': 'parent%2Fchild'})
{'uploadType': 'resumable', 'name': 'parent/child'})
self.assertEqual(rq[0]['headers'],
{'X-Upload-Content-Length': 6,
'X-Upload-Content-Type': 'application/unknown'})
Expand Down