Fix "bad" storage unit tests. #3627
Merged
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were "broken" by the release of google-resumable-media==0.2.0, but it just revealed that mocked response content was unicode when it should have been `bytes`.
googlebot
added
the
cla: yes
theacodes
approved these changes
Jul 18, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
These were "broken" by the release of google-resumable-media==0.2.0, but it just revealed that mocked response content was unicode when it should have been `bytes`.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
These were "broken" by the release of google-resumable-media==0.2.0, but it just revealed that mocked response content was unicode when it should have been `bytes`.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
These were "broken" by the release of google-resumable-media==0.2.0, but it just revealed that mocked response content was unicode when it should have been `bytes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were "broken" by the release of
google-resumable-media==0.2.0, but it just revealed that mocked response content wasunicodewhen it should have beenbytes./cc @jonparrott