-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making datastore Connection.rollback() return low-level protobuf. #3092
Conversation
""" | ||
request = _datastore_pb2.RollbackRequest() | ||
request.transaction = transaction_id | ||
# Nothing to do with this response, so just execute the method. | ||
self._datastore_api.rollback(project, request) | ||
# Response is empty (i.e. no fields) but we return it anyway. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question on the comment otherwise LGTM.
I'm going to go ahead and merge. |
Making datastore Connection.rollback() return low-level protobuf.
Towards #2746 (as were #3064 and #3066 and #3091). This approach is to slowly transition from our current approach to use the GAPIC generated surface.