Skip to content

Conversation

@daspecster
Copy link
Contributor

We haven't had a green travis build in a very long time.
Also, with the addition of Spanner, the master jobs reach the max time limit on Travis and just timeout anyway.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2017
@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2017

Also, with the addition of Spanner, the master jobs reach the max time limit on Travis and just timeout anyway.

This was true before Spanner.

I am 👍 on this but would rather we finish the migration from Travis to CircleCI first.

@daspecster
Copy link
Contributor Author

daspecster commented Feb 17, 2017

@dhermes what's missing in CiricleCI besides the PR builds only building/testing the changed services?

Since it builds everything each time, I think that overlaps the Travis coverage anyway.

@dhermes
Copy link
Contributor

dhermes commented Feb 18, 2017

  • the PR builds only building/testing the changed services
  • doing the same on merge builds (ci-diff-helper supports this)
  • making docs script less Travis specific
  • other parts of the iceberg?

@lukesneeringer
Copy link
Contributor

This is superceded by #3146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants