Correctly model JSON repr of complex nested records. #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
reviewed
Nov 30, 2016
| @@ -186,7 +186,7 @@ def test_w_scalar_subfield(self): | |||
| def test_w_repeated_subfield(self): | |||
| subfield = _Field('REPEATED', 'color', 'STRING') | |||
| field = _Field('REQUIRED', fields=[subfield]) | |||
| value = {'f': [{'v': ['red', 'yellow', 'blue']}]} | |||
| value = {'f': [{'v': [{'v': 'red'}, {'v': 'yellow'}, {'v': 'blue'}]}]} | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
AFAICT this looks good. The nesting is a bit mesmerizing though. I would think a system test might be helpful? Should we make an issue to add a system test after this PR? |
dhermes
reviewed
Dec 2, 2016
| converter = _CELLDATA_FROM_JSON[subfield.field_type] | ||
| if field.mode == 'REPEATED': | ||
| value = [converter(item, subfield) for item in cell['v']] | ||
| if subfield.mode == 'REPEATED': |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
approved these changes
Dec 2, 2016
|
@daspecster Good point -- I will add a system test using the examples I generated to test the stuff manually. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…data_types Correctly model JSON repr of complex nested records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2354.