Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass headers for streaming download. #2730

Merged
merged 1 commit into from
Nov 14, 2016
Merged

Pass headers for streaming download. #2730

merged 1 commit into from
Nov 14, 2016

Conversation

daspecster
Copy link
Contributor

Fixes #2715

@daspecster daspecster added the api: storage Issues related to the Cloud Storage API. label Nov 14, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2016
@daspecster daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2016
@daspecster daspecster force-pushed the fix-storage-stream-encrypted-download branch from 369034c to 14ce0b1 Compare November 14, 2016 18:29
@daspecster daspecster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 14, 2016
tseaver
tseaver suggested changes Nov 14, 2016
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after backing out the copyright year change.

system_tests/storage.py
@@ -1,4 +1,4 @@
# Copyright 2014 Google Inc.
# Copyright 2016 Google Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster daspecster force-pushed the fix-storage-stream-encrypted-download branch from 2c88c61 to 0c77284 Compare November 14, 2016 19:57
@daspecster
Copy link
Contributor Author

Squashed.

@daspecster
Copy link
Contributor Author

CircleCI passed so I'm going to merge. This run was just post squishing.

@daspecster daspecster merged commit 62fdca5 into googleapis:master Nov 14, 2016
@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
@daspecster daspecster deleted the fix-storage-stream-encrypted-download branch January 24, 2017 15:16
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2730 from daspecster/fix-storage-stream…
7e97e9e 
…-encrypted-download

Pass headers for streaming download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @tseaver @dhermes @googlebot