Skip to content

Speech Python 3.5 encoding content - 'not JSON serializable' #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daspecster merged 2 commits into from
Oct 11, 2016
Merged

Speech Python 3.5 encoding content - 'not JSON serializable' #2520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83000e9
Fix #2519, py3.5 encoding issue.
daspecster Oct 9, 2016
9e5b448
Use _from_bytes instead of decode()
daspecster Oct 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion speech/google/cloud/speech/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from base64 import b64encode

from google.cloud._helpers import _to_bytes
from google.cloud._helpers import _bytes_to_unicode
from google.cloud import client as client_module
from google.cloud.speech.connection import Connection
from google.cloud.speech.encoding import Encoding
Expand Down Expand Up @@ -237,7 +238,8 @@ def _build_request_data(sample, language_code=None, max_alternatives=None,
:returns: Dictionary with required data for Google Speech API.
"""
if sample.content is not None:
audio = {'content': b64encode(_to_bytes(sample.content))}
audio = {'content':
_bytes_to_unicode(b64encode(_to_bytes(sample.content)))}
else:
audio = {'uri': sample.source_uri}

Expand Down
8 changes: 5 additions & 3 deletions speech/unit_tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,15 @@ def test_create_sample_from_client(self):
self.assertEqual(content_sample.encoding, Encoding.FLAC)

def test_sync_recognize_content_with_optional_parameters(self):
import base64
from base64 import b64encode
from google.cloud._helpers import _to_bytes
from google.cloud._helpers import _bytes_to_unicode

from google.cloud.speech.encoding import Encoding
from google.cloud.speech.sample import Sample
from unit_tests._fixtures import SYNC_RECOGNIZE_RESPONSE

_B64_AUDIO_CONTENT = base64.b64encode(_to_bytes(self.AUDIO_CONTENT))
_AUDIO_CONTENT = _to_bytes(self.AUDIO_CONTENT)
_B64_AUDIO_CONTENT = _bytes_to_unicode(b64encode(_AUDIO_CONTENT))
RETURNED = SYNC_RECOGNIZE_RESPONSE
REQUEST = {
'config': {
Expand Down