Install 'grpc' deps into 'lint' environ; ignore 'google' imports under pylint

[tseaver]

Rationale:

pylint tries to guess at imports in the google namespace, and fails miserably. We test that those imports are valid all the time in unit tests anyway, so just disable them in pylint.

[tseaver]

@dhermes I've updated pylintrc_default to disable the redundant and buggy import-error check.

[dhermes]

the redundant and buggy

Evidence of this? Suggestions for a replacement to lint our imports? (I believe oauth2client uses a flake8 import check plugin.)

[tseaver]

With the import-error suppression commented out:

$ tox -e lint
...
************* Module gcloud.logging._gax
I:562, 0: Locally disabling too-many-branches (R0912) (locally-disabled)
I:608, 0: Locally enabling too-many-branches (R0912) (locally-enabled)
E: 23, 0: Unable to import 'google.logging.type.log_severity_pb2' (import-error)
E: 24, 0: Unable to import 'google.logging.v2.logging_config_pb2' (import-error)
E: 25, 0: Unable to import 'google.logging.v2.logging_metrics_pb2' (import-error)
E: 26, 0: Unable to import 'google.logging.v2.log_entry_pb2' (import-error)
...
************* Module gcloud.pubsub._gax
E: 21, 0: Unable to import 'google.pubsub.v1.pubsub_pb2' (import-error)
E: 22, 0: Unable to import 'google.pubsub.v1.pubsub_pb2' (import-error)

But, without touching the lint environment:

$ .tox/lint/bin/python -c "import google.logging.type.log_severity_pb2, google.logging.v2.logging_config_pb2, google.logging.v2.logging_metrics_pb2, google.logging.v2.log_entry_pb2, google.pubsub.v1.pubsub_pb2; print('OK')"
OK

In any case, it is pointless for them to check imports: we have tests for that.

[tseaver]

Maybe this is the relevant issue?

[dhermes]

@PCManticore has been a joy to work with on pylint issues. pylint is a static analysis checker lints via static analysis, hence the discrepancy between a working import and the pylint check. It seems we should file a bug with the GAX folks about whatever improper namespace package config is reference in pylint-dev/pylint#687

[tseaver]

@dhermes Why would we care about pylint reporting import errors: we know the imports are good, because 100% test coverage.

[dhermes]

OK LGTM, go ahead and merge

[PCManticore]

@dhermes Probably worth reporting an issue on the bug tracker? Sorry for chiming in on a merged PR.

[tseaver]

@PCManticore pylint-dev/pylint#687 looks like the open issue that matches: the various packages which install into the google namespace do not all use the same boilerplate for the namespace's __init__.py. GIven the widesspread adoption of pip/setuptools for installing namespace'd distributions, having the pkg_resources bit work as well as the pkgutils fallback would be ideal.