Appveyor: force install grpcio >= 1.0rc1. #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@dhermes I'm going to merge this one as soon as Travis green, to see if it can un-hork our Appveyor problems. |
| @@ -82,9 +82,9 @@ install: | |||
| # compiled extensions and are not provided as pre-built wheel packages, | |||
| # pip will build them from source using the MSVC compiler matching the | |||
| # target Python version and architecture | |||
| - "%CMD_IN_ENV% pip install wheel nose nose-exclude cryptography grpcio" | |||
| - "%CMD_IN_ENV% pip install wheel nose nose-exclude cryptography" | |||
| # Install sometimes-problemaatic gRPC-related dependencies | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. No need to wait on Travis but can you fix the typo I referred to? PS Thanks for creating the gRPC label. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #1863.