-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making grpcio install require fewer keystrokes. #1815
Conversation
LGTM |
|
||
gRPC is required for using the Cloud Bigtable API. As of May 2016, | ||
``grpcio`` is only supported in Python 2.7, so importing | ||
:mod:`gcloud.bigtable` will fail. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Adding an import error with a nice failure message in `gcloud.bigtable` in the absence of `grpcio` - Making `setup.py` include `grpcio` conditional on being Python 2.7 - Adding a warning to every single Bigtable docs page explaining that it can't be used outside of Python 2.7
@@ -5,7 +5,7 @@ Base for Everything | |||
|
|||
gRPC is required for using the Cloud Bigtable API. As of May 2016, | |||
``grpcio`` is only supported in Python 2.7, so importing | |||
:mod:`gcloud.bigtable` will fail. | |||
:mod:`gcloud.bigtable` in other versions of Python in other versions of Python will fail. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Minor comment re the banner -- otherwise LGTM 👍 |
Issue #1858 tracks the DRYness issue. |
gcloud.bigtable
in the absence ofgrpcio
setup.py
includegrpcio
conditional on being Python 2.7/cc @jgeewax